-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't export private headers from Buck target #37127
Conversation
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Base commit: 7e6f6aa |
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Summary: Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: b5636def92f93abdabfced5243156723d778b18a
a8c207b
to
ee46d78
Compare
Summary: X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: b12500c8a0c903ac1a8d9358b1449f8d527a91a5
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 556cabcea962666b06098eb845ad414527a3fef0
ee46d78
to
b767f8c
Compare
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 5c7aaf6c4e83ffe51ad1a59313eb5b518987a28e
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 9996f0b0d02759eb6e7afd8469d2317471162378
b767f8c
to
5df47ea
Compare
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 9520d3b4e8d7ace9aa039379d60b58a1ae1278fc
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: e2c453e903c919dd9c6875208451295edc79a656
5df47ea
to
24a7475
Compare
This pull request was exported from Phabricator. Differential Revision: D45339425 |
24a7475
to
2a1dfd0
Compare
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: bdfbb4a3bc32bc005dbb639c5d7ab532ddd2c07a
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 29f1f31d15ea3f70bdca20ce5991e9f8c1fab4fe
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 61d9b442a9a16a409da37c7ad6d5fa1b58922de9
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 973984f8e9963a17cf9fefa5b024669ba9c6e9f7
2a1dfd0
to
2ea0472
Compare
This pull request was exported from Phabricator. Differential Revision: D45339425 |
4fe6881
to
731425f
Compare
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 764517903b9b8ad1f55dded6d11d8388163f339e
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 8a156e55368b4a3e896d93f6b43ed05477c37e8c
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 59af51541ee952c831a81e7f2a37d53f88e2c5c7
731425f
to
4af113e
Compare
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 9a00c89c4d6ccfa33db7064c34b5cf5d400d58fe
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 630791a0fec1e4842c876151e3de3d6bec7bb9b9
4af113e
to
ab2b038
Compare
This pull request was exported from Phabricator. Differential Revision: D45339425 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: c338c44f8ac94c39ea61d3a9c210fad5a239d52a
ab2b038
to
39433fc
Compare
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 30a23813bf756281d56b6078268194ba52fd3d4a
39433fc
to
809b5ac
Compare
This pull request was exported from Phabricator. Differential Revision: D45339425 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: a74f0b6e9bb575963c1af3d5adc513c53edc8d51
809b5ac
to
ab73eab
Compare
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 5b2fd84c6d1e23d32c31a1c5c59775a829b758fd
This pull request was exported from Phabricator. Differential Revision: D45339425 |
ab73eab
to
ef57f4f
Compare
Summary: Pull Request resolved: #1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: eb7ef151ad2467d7c3370cd7c10d47e8db9496a0
This pull request has been merged in d5dad06. |
Summary: X-link: facebook/yoga#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: eb7ef151ad2467d7c3370cd7c10d47e8db9496a0
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: eb7ef151ad2467d7c3370cd7c10d47e8db9496a0
Summary:
This prevents targets which include Yoga from using its private APIs.
Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a
yoga-private-api
target for now to keep using these headers while making it unlikely new usages will show up.Reviewed By: javache
Differential Revision: D45339425