Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RN CLI, add @react-native/metro-config to template (#36623) #36697

Closed
wants to merge 1 commit into from

Commits on Mar 30, 2023

  1. Bump RN CLI, add @react-native/metro-config to template (facebook#36623)

    Summary:
    Pull Request resolved: facebook#36623
    
    Changelog:
    [General][Changed] - The default `metro.config.js` in apps now extends `react-native/metro-config`, and should be updated in existing apps.
    
    ~~`react-native/rn-get-polyfills.js` is removed and should be updated to `react-native/js-polyfills` in existing apps (this is part of the new default config).~~
    
    #publish-packages-to-npm
    
    ## Context
    
    ### React Native Metro config → React Native repo (facebook#36502)
    
    We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package.
    
    This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users.
    
    **See full motivation, design, and test plan (which previewed the CLI bump) here: facebook#36502
    
    ## Changes
    
    NOTE: This PR is pending the inclusion of a bump to `react-native-community/cli`, and will be sequenced after react-native-community/cli#1875 is merged.
    
    - Upgrade `react-native-community/cli` to `11.0.0`, upgrade all `metro` packages to `0.76.0` (version distributed in this CLI release).
    - Update the `metro.config.js` file in `packages/react-native/template/`.
        - Now merges defaults from `react-native/metro-config`, and can be used with CLI >= 11.0.0.
    - Update the `metro.config.js` files for `packages/react-native/` and `packages/rn-tester/` (these are integration test locations).
        - Now merges defaults from `react-native/metro-config`, and can be used with CLI >= 11.0.0.
    
    Changes to `react-native/metro-config` — `0.72.1` (prepared but not depended on yet):
    
    - Export `mergeConfig` util (removing direct `metro-config` dependency in consuming projects).
    - Explicitly depend on `metro-react-native-babel-transformer` and `metro-runtime` (transitively included today).
    
    Reviewed By: cortinico, blakef
    
    Differential Revision: D44099691
    
    fbshipit-source-id: 283f5b4a9df005034e9c671a37a3d75b825f10b8
    huntie authored and facebook-github-bot committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    96c5216 View commit details
    Browse the repository at this point in the history