deprecate ReactModuleWithSpec #36673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44450959 |
|
This pull request was exported from Phabricator. Differential Revision: D44450959 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: facebook#36673 Changelog: [Android][Removed] in this change, we can safely get rid of ReactModuleWithSpec because it is no longer used. this change should not be breaking, since this class did nothing for product developers in the first place. Differential Revision: D44450959 fbshipit-source-id: 4826e0b13e9c79b43b23afe5b71b7bcbb607ced9
philIip
force-pushed
the
export-D44450959
branch
from
bcc4342
to
e3951a0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44450959 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: facebook#36673 Changelog: [Android][Removed] in this change, we can safely get rid of ReactModuleWithSpec because it is no longer used. this change should not be breaking, since this class did nothing for product developers in the first place. Differential Revision: D44450959 fbshipit-source-id: 1904b9289c409a8136e0ab43f2315e2fd0c612f6
philIip
force-pushed
the
export-D44450959
branch
from
e3951a0
to
f53fe08
Compare
Base commit: a7f7f8a |
|
This pull request was exported from Phabricator. Differential Revision: D44450959 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: facebook#36673 Changelog: [Android][Removed] in this change, we can safely get rid of ReactModuleWithSpec because it is no longer used. this change should not be breaking, since this class did nothing for product developers in the first place. Differential Revision: D44450959 fbshipit-source-id: da97e365c25d9d0ead1adb0d013ab05a2d475e80
philIip
force-pushed
the
export-D44450959
branch
from
f53fe08
to
2ca787d
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: facebook#36673 Changelog: [Android][Deprecated] in this change, we deprecate ReactModuleWithSpec because it can be replaced with the TurboModule interface which better describes our generated modules. Differential Revision: D44450959 fbshipit-source-id: a4a02b8ed52be36b9ed902a9641c530ad8fa6bec
philIip
force-pushed
the
export-D44450959
branch
from
2ca787d
to
6651a15
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44450959 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44450959 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: facebook#36673 Changelog: [Android][Deprecated] in this change, we deprecate ReactModuleWithSpec because it can be replaced with the TurboModule interface which better describes our generated modules. Differential Revision: D44450959 fbshipit-source-id: b8944e379238b36bfa72c289722c7663ee1181a6
philIip
force-pushed
the
export-D44450959
branch
from
6651a15
to
ebabc9d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44450959 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 29, 2023
Summary: Pull Request resolved: facebook#36673 Changelog: [Android][Deprecated] in this change, we deprecate ReactModuleWithSpec because it can be replaced with the TurboModule interface which better describes our generated modules. Differential Revision: D44450959 fbshipit-source-id: 9dc711112c131321d1663fc3fc26972c231526f1
philIip
force-pushed
the
export-D44450959
branch
from
ebabc9d
to
965d6b3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44450959 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Mar 29, 2023
Summary: Pull Request resolved: facebook#36673 Changelog: [Android][Deprecated] in this change, we deprecate ReactModuleWithSpec because it can be replaced with the TurboModule interface which better describes our generated modules. Differential Revision: D44450959 fbshipit-source-id: a5f13c627a42b76f3dc7f5721899350355434f30
philIip
force-pushed
the
export-D44450959
branch
from
965d6b3
to
06718f5
Compare
Differential Revision: D44450433 fbshipit-source-id: f6724daa3901e924af7eb0e9dce05406c77b6169
Differential Revision: D44450687 fbshipit-source-id: 572174ac6cbfec3712b3ec4f063790251d7dc4ca
Summary: Pull Request resolved: facebook#36673 Changelog: [Android][Deprecated] in this change, we deprecate ReactModuleWithSpec because it can be replaced with the TurboModule interface which better describes our generated modules. Differential Revision: D44450959 fbshipit-source-id: 4dd1106fcef7806fee92bcc1debc79998fc8eee5
philIip
force-pushed
the
export-D44450959
branch
from
06718f5
to
8ef7591
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44450959 |
|
This pull request has been merged in a4fe9b2. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36673 Changelog: [Android][Deprecated] in this change, we deprecate ReactModuleWithSpec because it can be replaced with the TurboModule interface which better describes our generated modules. Reviewed By: cortinico Differential Revision: D44450959 fbshipit-source-id: adab192593843926f35bdbeb346ef374dd80e615
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36673 Changelog: [Android][Deprecated] in this change, we deprecate ReactModuleWithSpec because it can be replaced with the TurboModule interface which better describes our generated modules. Reviewed By: cortinico Differential Revision: D44450959 fbshipit-source-id: adab192593843926f35bdbeb346ef374dd80e615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Android][Removed]
in this change, we can safely get rid of ReactModuleWithSpec because it is no longer used.
this change should not be breaking, since this class did nothing for product developers in the first place.
Differential Revision: D44450959