Fix paths in objc-test.sh, temporarily exclude /IntegrationTests #36648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44416533 |
Base commit: 04df252 |
|
This pull request was exported from Phabricator. Differential Revision: D44416533 |
3 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D44416533 |
|
This pull request was exported from Phabricator. Differential Revision: D44416533 |
|
This pull request was exported from Phabricator. Differential Revision: D44416533 |
) Summary: Pull Request resolved: #36648 Changelog: [Internal] Blocker for #36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI. - Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory. - **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!). - Also fix `yarn start` script in `packages/rn-tester`. Reviewed By: cipolleschi Differential Revision: D44416533 fbshipit-source-id: 2b1709b05f315630af3cd3b8dcfa1afd13116e0b
|
This pull request was exported from Phabricator. Differential Revision: D44416533 |
|
This pull request was exported from Phabricator. Differential Revision: D44416533 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Mar 27, 2023
…ebook#36648) Summary: Pull Request resolved: facebook#36648 Changelog: [Internal] Blocker for facebook#36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI. - Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory. - **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!). - Also fix `yarn start` script in `packages/rn-tester`. Reviewed By: cipolleschi Differential Revision: D44416533 fbshipit-source-id: e200d7d1462d5ca4e263e21ff1e885929970068b
|
This pull request has been merged in 32e836d. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…ebook#36648) Summary: Pull Request resolved: facebook#36648 Changelog: [Internal] Blocker for facebook#36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI. - Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory. - **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!). - Also fix `yarn start` script in `packages/rn-tester`. Reviewed By: cipolleschi Differential Revision: D44416533 fbshipit-source-id: 59c5b743d9d8fda206a12e37d94324ed9bfd703e
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ebook#36648) Summary: Pull Request resolved: facebook#36648 Changelog: [Internal] Blocker for facebook#36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI. - Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory. - **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!). - Also fix `yarn start` script in `packages/rn-tester`. Reviewed By: cipolleschi Differential Revision: D44416533 fbshipit-source-id: 59c5b743d9d8fda206a12e37d94324ed9bfd703e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Blocker for #36623. The
test-iosjob in CI was misconfigured following the monorepo migration — and becomes load-bearing with the incoming version of React Native CLI.objc-test.shto run inpackages/rn-tester, and exclude tests under/IntegrationTestswhich are outside of a Metro project directory (before the monorepo changes, this was logically insidepackages/react-native).IntegrationTests, which @cipolleschi is following up (thanks!).yarn startscript inpackages/rn-tester.Differential Revision: D44416533