fix: make cursor center for different line height #36586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: cf43f9c |
|
@genkikondo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@genkikondo merged this pull request in 987c6fd. |
6 tasks
|
@genkikondo please check my concern here. This PR should still not be merged. bug.mp4 |
|
@situchan I'm reverting now. Thanks so much for flagging. |
|
This pull request has been reverted by ebc97a6. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Currently in multiline input the cursor touches the previous line. So this reduces its height sets its position so that I does not touch previous line. This PR will also fix the issue facebook#28012 (Problem with TextInput lineHeight on iOS) This RP will fix the issue caused in [PR](facebook#36484) Changelog: [iOS][Added] - Fixed cursor height on multiline text input Pull Request resolved: facebook#36586 Test Plan: Tested for different cursor height https://user-images.githubusercontent.com/46092576/227004355-3886a0b5-7cdb-4fdc-a16b-3c4abb729737.mov https://user-images.githubusercontent.com/46092576/227004361-48099f81-9f52-460d-8ae8-d0ddb09dc47d.mov Reviewed By: javache Differential Revision: D44307457 Pulled By: genkikondo fbshipit-source-id: afeea5605ed8557cdeec1e62324c85665ce367d6
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Currently in multiline input the cursor touches the previous line. So this reduces its height sets its position so that I does not touch previous line. This PR will also fix the issue facebook#28012 (Problem with TextInput lineHeight on iOS) This RP will fix the issue caused in [PR](facebook#36484) Changelog: [iOS][Added] - Fixed cursor height on multiline text input Pull Request resolved: facebook#36586 Test Plan: Tested for different cursor height https://user-images.githubusercontent.com/46092576/227004355-3886a0b5-7cdb-4fdc-a16b-3c4abb729737.mov https://user-images.githubusercontent.com/46092576/227004361-48099f81-9f52-460d-8ae8-d0ddb09dc47d.mov Reviewed By: javache Differential Revision: D44307457 Pulled By: genkikondo fbshipit-source-id: afeea5605ed8557cdeec1e62324c85665ce367d6
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR was closed because it has been stalled for 7 days with no activity. |
|
Unsubscribe
William Pope Jr
…On Thu, Sep 28, 2023, 1:16 AM github-actions[bot] ***@***.***> wrote:
This PR was closed because it has been stalled for 7 days with no activity.
—
Reply to this email directly, view it on GitHub
<#36586 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALNSC3GCWYQ7NGQNX7BAGHTX4UBZBANCNFSM6AAAAAAWEGUNFI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently in multiline input the cursor touches the previous line.
So this reduces its height sets its position so that I does not touch previous line.
This PR will also fix the issue #28012 (Problem with TextInput lineHeight on iOS)
This RP will fix the issue caused in
PR
Changelog
[IOS] [ADDED] - Fixed cursor height on multiline text input
Test Plan
Tested for different cursor height
Screen.Recording.2023-03-22.at.11.17.31.PM.mov
Screen.Recording.2023-03-22.at.11.19.21.PM.mov