Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimimize EditText Spans 9/9: Remove addSpansForMeasurement #36575

Closed
wants to merge 1 commit into from

Commits on Mar 25, 2023

  1. Mimimize EditText Spans 9/9: Remove addSpansForMeasurement() (faceboo…

    …k#36575)
    
    Summary:
    Pull Request resolved: facebook#36575
    
    This is part of a series of changes to minimize the number of spans committed to EditText, as a mitigation for platform issues on Samsung devices. See this [GitHub thread]( facebook#35936 (comment)) for greater context on the platform behavior.
    
    D23670779 addedd a previous mechanism to add spans for measurement caching, like we needed to do as part of this change. It is called in more specific cases (e.g. when there is a text hint but no text), but it edits the live EditText spannable instead of the cache copy, and does not handle nested text at all.
    
    We are already adding spans back to the input after this, behind everything else, and can replace it with the code we have been adding.
    
    Changelog:
    [Android][Fixed] - Mimimize EditText Spans 9/9: Remove `addSpansForMeasurement()`
    
    Reviewed By: javache
    
    Differential Revision: D44298159
    
    fbshipit-source-id: 482cc46f8cf4d1498543e03a69a1b01c9faf1aa0
    NickGerleman authored and facebook-github-bot committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    6fabd32 View commit details
    Browse the repository at this point in the history