Bail on realizing region around last focused cell if we don't know where it is #36541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44221162 |
Base commit: aab4763 |
|
This pull request was exported from Phabricator. Differential Revision: D44221162 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 20, 2023
…ere it is (facebook#36541) Summary: Pull Request resolved: facebook#36541 We only know where the last focused cell lives after it is rendered. Apart from dead refs handled in D43835135, this means items added or removed before the focused cell will lead to a stale last index for the next state update. We don't have a good way to correlate cells after data change. This effects the implementation for [`maintainVisibleContentPosition`](facebook#35993) as well, but needs some thought on the right way to handle it. For now, we bail when we don't know where the last focused cell lives. Changelog: [General][Fixed] - Bail on realizing region around last focused cell if we don't know where it is Differential Revision: D44221162 fbshipit-source-id: 6e7da6e7eadf6dccfbcb4d182b47df20c1745475
NickGerleman
force-pushed
the
export-D44221162
branch
from
a4ee821 to
2c00fc9
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 22, 2023
…ere it is (facebook#36541) Summary: Pull Request resolved: facebook#36541 We only know where the last focused cell lives after it is rendered. Apart from dead refs handled in D43835135, this means items added or removed before the focused cell will lead to a stale last index for the next state update. We don't have a good way to correlate cells after data change. This effects the implementation for [`maintainVisibleContentPosition`](facebook#35993) as well, but needs some thought on the right way to handle it. For now, we bail when we don't know where the last focused cell lives. Changelog: [General][Fixed] - Bail on realizing region around last focused cell if we don't know where it is Differential Revision: D44221162 fbshipit-source-id: 30e842261dfc0a4a17944430c65f487fb414b4b1
NickGerleman
force-pushed
the
export-D44221162
branch
from
2c00fc9 to
5f7cbe1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44221162 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44221162 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 24, 2023
…ere it is (facebook#36541) Summary: Pull Request resolved: facebook#36541 We only know where the last focused cell lives after it is rendered. Apart from dead refs handled in D43835135, this means items added or removed before the focused cell will lead to a stale last index for the next state update. We don't have a good way to correlate cells after data change. This effects the implementation for [`maintainVisibleContentPosition`](facebook#35993) as well, but needs some thought on the right way to handle it. For now, we bail when we don't know where the last focused cell lives. Changelog: [General][Fixed] - Bail on realizing region around last focused cell if we don't know where it is Reviewed By: yungsters Differential Revision: D44221162 fbshipit-source-id: 9478eb383879fc125f091b49159f0daad23f57e9
NickGerleman
force-pushed
the
export-D44221162
branch
from
5f7cbe1 to
cc98ec5
Compare
…ere it is (facebook#36541) Summary: Pull Request resolved: facebook#36541 We only know where the last focused cell lives after it is rendered. Apart from dead refs handled in D43835135, this means items added or removed before the focused cell will lead to a stale last index for the next state update. We don't have a good way to correlate cells after data change. This effects the implementation for [`maintainVisibleContentPosition`](facebook#35993) as well, but needs some thought on the right way to handle it. For now, we bail when we don't know where the last focused cell lives. Changelog: [General][Fixed] - Bail on realizing region around last focused cell if we don't know where it is Reviewed By: yungsters Differential Revision: D44221162 fbshipit-source-id: 773de08da3068acb89198648690bccb79156c985
|
This pull request was exported from Phabricator. Differential Revision: D44221162 |
NickGerleman
force-pushed
the
export-D44221162
branch
from
cc98ec5 to
58e5e24
Compare
|
This pull request has been merged in 776fe7a. |
kelset
pushed a commit
that referenced
this pull request
Mar 29, 2023
…ere it is (#36541) Summary: Pull Request resolved: #36541 We only know where the last focused cell lives after it is rendered. Apart from dead refs handled in D43835135, this means items added or removed before the focused cell will lead to a stale last index for the next state update. We don't have a good way to correlate cells after data change. This effects the implementation for [`maintainVisibleContentPosition`](#35993) as well, but needs some thought on the right way to handle it. For now, we bail when we don't know where the last focused cell lives. Changelog: [General][Fixed] - Bail on realizing region around last focused cell if we don't know where it is Reviewed By: yungsters Differential Revision: D44221162 fbshipit-source-id: 8fc7e726fe13c62b98870600563857bb89290280
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…ere it is (facebook#36541) Summary: Pull Request resolved: facebook#36541 We only know where the last focused cell lives after it is rendered. Apart from dead refs handled in D43835135, this means items added or removed before the focused cell will lead to a stale last index for the next state update. We don't have a good way to correlate cells after data change. This effects the implementation for [`maintainVisibleContentPosition`](facebook#35993) as well, but needs some thought on the right way to handle it. For now, we bail when we don't know where the last focused cell lives. Changelog: [General][Fixed] - Bail on realizing region around last focused cell if we don't know where it is Reviewed By: yungsters Differential Revision: D44221162 fbshipit-source-id: 8fc7e726fe13c62b98870600563857bb89290280
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ere it is (facebook#36541) Summary: Pull Request resolved: facebook#36541 We only know where the last focused cell lives after it is rendered. Apart from dead refs handled in D43835135, this means items added or removed before the focused cell will lead to a stale last index for the next state update. We don't have a good way to correlate cells after data change. This effects the implementation for [`maintainVisibleContentPosition`](facebook#35993) as well, but needs some thought on the right way to handle it. For now, we bail when we don't know where the last focused cell lives. Changelog: [General][Fixed] - Bail on realizing region around last focused cell if we don't know where it is Reviewed By: yungsters Differential Revision: D44221162 fbshipit-source-id: 8fc7e726fe13c62b98870600563857bb89290280
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We only know where the last focused cell lives after it is rendered. Apart from dead refs handled in D43835135, this means items added or removed before the focused cell will lead to a stale last index for the next state update.
We don't have a good way to correlate cells after data change. This effects the implementation for
maintainVisibleContentPositionas well, but needs some thought on the right way to handle it. For now, we bail when we don't know where the last focused cell lives.Changelog:
[General][Fixed] - Bail on realizing region around last focused cell if we don't know where it is
Differential Revision: D44221162