Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prefab prefix for fabricjni #35648

Closed
wants to merge 1 commit into from
Closed

Fix prefab prefix for fabricjni #35648

wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
The fabricjni prefab module was missing the react/fabric prefix.
I'm adding it here.
Ref: reactwg/react-native-releases#41 (reply in thread)

Changelog:
[Internal] [Changed] - Fix prefab prefix for fabricjni

Differential Revision: D42047434

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 14, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42047434

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5663671
Branch: main

@pull-bot
Copy link

PR build artifact for 1a0d7d2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for 1a0d7d2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@cortinico @facebook-github-bot
Fix prefab prefix for fabricjni (facebook#35648)
7ac8fa9 
Summary:
Pull Request resolved: facebook#35648

The `fabricjni` prefab module was missing the `react/fabric` prefix.
I'm adding it here.
Ref: reactwg/react-native-releases#41 (reply in thread)

Changelog:
[Internal] [Changed] - Fix prefab prefix for fabricjni

Differential Revision: D42047434

fbshipit-source-id: 30396145a0a9854feec00a2cdf9dcb1225ccd41d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42047434

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,464,867 +0
android hermes armeabi-v7a 7,784,482 +0
android hermes x86 8,939,275 +0
android hermes x86_64 8,797,363 +0
android jsc arm64-v8a 9,657,526 +0
android jsc armeabi-v7a 8,390,394 +0
android jsc x86 9,721,241 +0
android jsc x86_64 10,198,762 +0

Base commit: 5663671
Branch: main

@pull-bot
Copy link

PR build artifact for 7ac8fa9 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for 7ac8fa9 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3487640.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 15, 2022
cipolleschi pushed a commit that referenced this pull request Dec 19, 2022
@cortinico
Fix prefab prefix for fabricjni (#35648)
621d901 
Summary:
Pull Request resolved: #35648

The `fabricjni` prefab module was missing the `react/fabric` prefix.
I'm adding it here.
Ref: reactwg/react-native-releases#41 (reply in thread)

Changelog:
[Internal] [Changed] - Fix prefab prefix for fabricjni

Reviewed By: cipolleschi

Differential Revision: D42047434

fbshipit-source-id: 202db49cd1ada2462652dbd7e56bad6779c263ac
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@cortinico @OlimpiaZurek
Fix prefab prefix for fabricjni (facebook#35648)
afef89a 
Summary:
Pull Request resolved: facebook#35648

The `fabricjni` prefab module was missing the `react/fabric` prefix.
I'm adding it here.
Ref: reactwg/react-native-releases#41 (reply in thread)

Changelog:
[Internal] [Changed] - Fix prefab prefix for fabricjni

Reviewed By: cipolleschi

Differential Revision: D42047434

fbshipit-source-id: 202db49cd1ada2462652dbd7e56bad6779c263ac
@cipolleschi cipolleschi mentioned this pull request Aug 16, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Merged
This was referenced Jan 8, 2024
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Mar 6, 2024
Merged
@cipolleschi cipolleschi mentioned this pull request Apr 5, 2024
Closed
@cipolleschi cipolleschi mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cortinico @facebook-github-bot @analysis-bot @pull-bot