Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(react-native-github): move ProgressViewIOS to internal #35277

Closed
wants to merge 1 commit into from
Closed

refactor(react-native-github): move ProgressViewIOS to internal #35277

wants to merge 1 commit into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Nov 9, 2022

Summary:

Changelog:

[JS][Removed] - removed ProgressViewIOS module
[iOS][Removed] - removed native iOS sources of ProgressViewIOS

Differential Revision: D40937475

@hoxyq @facebook-github-bot
refactor(react-native-github): move ProgressViewIOS to internal
bd44e75 
Summary:
# Changelog:
[JS][Removed] - removed ProgressViewIOS module
[iOS][Removed] - removed native iOS sources of ProgressViewIOS

Differential Revision: D40937475

fbshipit-source-id: eb77a9e3a351b1b8f83e04e232e0eb5ffdc3a038
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 9, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40937475

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,068,484 -1,554
android hermes armeabi-v7a 6,440,274 -1,900
android hermes x86 7,483,399 -1,634
android hermes x86_64 7,343,189 -1,423
android jsc arm64-v8a 8,933,164 -1,386
android jsc armeabi-v7a 7,666,936 -1,725
android jsc x86 8,993,153 -1,446
android jsc x86_64 9,472,288 -1,244

Base commit: 5744b21
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5744b21
Branch: main

@pull-bot
Copy link

pull-bot commented Nov 9, 2022

PR build artifact for bd44e75 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Nov 9, 2022

PR build artifact for bd44e75 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@hoxyq hoxyq deleted the export-D40937475 branch November 17, 2022 21:09
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@hoxyq @OlimpiaZurek
refactor(react-native-github): move ProgressViewIOS to internal (face…
a992198 
…book#35277)

Summary:
Pull Request resolved: facebook#35277

# Changelog:
[JS][Removed] - removed ProgressViewIOS module
[iOS][Removed] - removed native iOS sources of ProgressViewIOS

Reviewed By: lunaleaps

Differential Revision: D40937475

fbshipit-source-id: 9060adf3c99727af4eeffc767ccfd0a70574859d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner Type: Removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hoxyq @facebook-github-bot @analysis-bot @pull-bot @react-native-bot