[Bugfix] Within NavigatorIOS, navigator.replace doesn't update the navigation bar. #3516
Conversation
rocman
commented
Oct 19, 2015
rocman
commented
- let the RCTNavItem refer to the NavigationBar and the NavigtaionItem, so that it can forward the modifications to them. And such, to fix the bug that props.navigator.replace does not update the NavigationBar.
- Provide a update method to modify the current route
…vigation bar. 1. let the RCTNavItem refers to the NavigationBar and the NavigtaionItem, so that it can forward the modifications to them. And such, to fix the bug that props.navigator.replace does not update the NavigationBar. 2. Provide a update method to modify the current route
When there is no component or passProps on the route, skip updating the component. So as to allow modifying the navigation bar without rerendering the component. And so to make it possible to set up the navigation bar according to the state in the component render, which is important.
|
By analyzing the blame information on this pull request, we identified @ide, @nicklockwood and @mrspeaker to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
rocman
changed the title
|
@rocman updated the pull request. |
|
@rocman updated the pull request. |
|
@rocman updated the pull request. |
|
Somebody? |
| @@ -13,6 +13,9 @@ | |||
|
|
|||
| @interface RCTNavItem : UIView | |||
|
|
|||
| @property (nonatomic, assign) UINavigationBar *navigationBar; | |||
There was a problem hiding this comment.
These are pointers, they should be strong or possibly weak, but definitely not assign.
following @nicklockwood’s suggestions, i’ve adjusted the property declarations for navigationBar and navigationItem, and simplified the logics that adjust the the buttons.
|
@rocman updated the pull request. |
|
@rocman updated the pull request. |
|
@rocman updated the pull request. |
|
@rocman updated the pull request. |
|
@rocman updated the pull request. |
|
@rocman updated the pull request. |
|
I don't understand why the checks failed... |
|
will version 0.14.0 will fix this ? |
|
I'm suffering from the failure of ci build checks and don't know how to fix it. So the pull request is still uncommitted. |
|
@rocman updated the pull request. |
