-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): add wanted dependencies to remove yarn warnings #35088
Conversation
Base commit: fd91748 |
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a convention (internally enforced, possibly?) of alphabetically ordering dependencies but otherwise LGTM - thanks @kelset
Co-authored-by: Rob Hogan <2590098+robhogan@users.noreply.github.com>
Co-authored-by: Rob Hogan <2590098+robhogan@users.noreply.github.com>
@robhogan no problem, thanks for the suggestions, I've applied them! Is there some tooling that we could use to automate this? Kind of like prettier but for package.json? 😅 |
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yeah we should, tbh I thought we had an autofix lint rule for it already. Yarn and NPM auto-sort whenever they modify the file iirc, but it looks like we don't have any check - |
This pull request was successfully merged by @kelset in 8422c53. When will my fix make it into a release? | Upcoming Releases |
This pull request has been reverted by cf5addf. |
Reopening as this was reverted due to an (apparently) missing internal dependency that previously worked transitively. Meta folks: See D40716713 before re-landing. |
@robhogan quick check, anything I can do to help get this in? do you want me to rebase it on top of main? |
Sorry about this, nothing you can do from the OSS end. Removing the If it'd help you to get this in, you could submit a new PR (has to be new - this one can't be re-imported now it's been committed) without the Otherwise, I'm hoping we can unblock this within a few days. |
Summary: This is take 2 of this #35088, see this comment for why #35088 (comment) I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install. It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - add wanted dependencies to remove yarn warnings Pull Request resolved: #35122 Test Plan: ### Before <img width="1920" alt="Screenshot 2022-10-26 at 10 53 32" src="https://user-images.githubusercontent.com/16104054/197996489-f463be29-b35b-45cc-9d9c-2d176579fb7d.png"> ### After <img width="947" alt="Screenshot 2022-10-26 at 10 52 19" src="https://user-images.githubusercontent.com/16104054/197996505-3d60b319-006b-45ab-83bf-2f431272fdcd.png"> Reviewed By: cortinico Differential Revision: D40804260 Pulled By: rshest fbshipit-source-id: 86af14c885d6d63a0d60bb85f204d17d8757f72a
the other one got merged, so I'll close this one off |
…k#35088) Summary: I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install. It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier. Also, while doing that I found a dependency that was lying there unused for 2 years so took care of it. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - add wanted dependencies to remove yarn warnings Pull Request resolved: facebook#35088 Test Plan: ### Before <img width="1920" alt="Screenshot 2022-10-26 at 10 53 32" src="https://user-images.githubusercontent.com/16104054/197996489-f463be29-b35b-45cc-9d9c-2d176579fb7d.png"> ### After <img width="947" alt="Screenshot 2022-10-26 at 10 52 19" src="https://user-images.githubusercontent.com/16104054/197996505-3d60b319-006b-45ab-83bf-2f431272fdcd.png"> Reviewed By: jacdebug Differential Revision: D40716713 Pulled By: robhogan fbshipit-source-id: eeb95a91c6cdf37edfe868fefe4ba04aebe500ec
…k#35122) Summary: This is take 2 of this facebook#35088, see this comment for why facebook#35088 (comment) I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install. It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - add wanted dependencies to remove yarn warnings Pull Request resolved: facebook#35122 Test Plan: ### Before <img width="1920" alt="Screenshot 2022-10-26 at 10 53 32" src="https://user-images.githubusercontent.com/16104054/197996489-f463be29-b35b-45cc-9d9c-2d176579fb7d.png"> ### After <img width="947" alt="Screenshot 2022-10-26 at 10 52 19" src="https://user-images.githubusercontent.com/16104054/197996505-3d60b319-006b-45ab-83bf-2f431272fdcd.png"> Reviewed By: cortinico Differential Revision: D40804260 Pulled By: rshest fbshipit-source-id: 86af14c885d6d63a0d60bb85f204d17d8757f72a
Summary
I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install.
It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier.
Also, while doing that I found a dependency that was lying there unused for 2 years so took care of it.
Changelog
[General] [Fixed] - add wanted dependencies to remove yarn warnings
Test Plan
Before
After