Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add wanted dependencies to remove yarn warnings #35088

Closed
wants to merge 5 commits into from

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Oct 26, 2022

Summary

I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install.

It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier.

Also, while doing that I found a dependency that was lying there unused for 2 years so took care of it.

Changelog

[General] [Fixed] - add wanted dependencies to remove yarn warnings

Test Plan

Before

Screenshot 2022-10-26 at 10 53 32

After

Screenshot 2022-10-26 at 10 52 19

@kelset kelset requested a review from hramos as a code owner October 26, 2022 09:57
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Oct 26, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: fd91748
Branch: main

@facebook-github-bot
Copy link
Contributor

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@robhogan robhogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a convention (internally enforced, possibly?) of alphabetically ordering dependencies but otherwise LGTM - thanks @kelset

packages/hermes-inspector-msggen/package.json Outdated Show resolved Hide resolved
packages/react-native-bots/package.json Outdated Show resolved Hide resolved
robhogan and others added 3 commits October 26, 2022 13:00
Co-authored-by: Rob Hogan <2590098+robhogan@users.noreply.github.com>
Co-authored-by: Rob Hogan <2590098+robhogan@users.noreply.github.com>
@kelset
Copy link
Contributor Author

kelset commented Oct 26, 2022

@robhogan no problem, thanks for the suggestions, I've applied them! Is there some tooling that we could use to automate this? Kind of like prettier but for package.json? 😅

@facebook-github-bot
Copy link
Contributor

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robhogan
Copy link
Contributor

robhogan commented Oct 26, 2022

@robhogan no problem, thanks for the suggestions, I've applied them! Is there some tooling that we could use to automate this? Kind of like prettier but for package.json? 😅

Yeah we should, tbh I thought we had an autofix lint rule for it already. Yarn and NPM auto-sort whenever they modify the file iirc, but it looks like we don't have any check - package-json/sort-collections would work. CC @cipolleschi

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @kelset in 8422c53.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 26, 2022
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by cf5addf.

@robhogan robhogan reopened this Oct 26, 2022
@robhogan
Copy link
Contributor

Reopening as this was reverted due to an (apparently) missing internal dependency that previously worked transitively.

Meta folks: See D40716713 before re-landing.

@kelset
Copy link
Contributor Author

kelset commented Oct 28, 2022

@robhogan quick check, anything I can do to help get this in? do you want me to rebase it on top of main?

@robhogan
Copy link
Contributor

@robhogan quick check, anything I can do to help get this in? do you want me to rebase it on top of main?

Sorry about this, nothing you can do from the OSS end. Removing the @reactions/component dependency is tripping up Flow internally for reasons that are unclear at the moment, some config/resolution bug - we're working on it.

If it'd help you to get this in, you could submit a new PR (has to be new - this one can't be re-imported now it's been committed) without the @reactions/component removal, that should be a straightforward merge.

Otherwise, I'm hoping we can unblock this within a few days.

@kelset
Copy link
Contributor Author

kelset commented Oct 28, 2022

@robhogan here you go: #35122

facebook-github-bot pushed a commit that referenced this pull request Oct 28, 2022
Summary:
This is take 2 of this #35088, see this comment for why #35088 (comment)

I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install.

It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Fixed] - add wanted dependencies to remove yarn warnings

Pull Request resolved: #35122

Test Plan:
### Before

<img width="1920" alt="Screenshot 2022-10-26 at 10 53 32" src="https://user-images.githubusercontent.com/16104054/197996489-f463be29-b35b-45cc-9d9c-2d176579fb7d.png">

### After

<img width="947" alt="Screenshot 2022-10-26 at 10 52 19" src="https://user-images.githubusercontent.com/16104054/197996505-3d60b319-006b-45ab-83bf-2f431272fdcd.png">

Reviewed By: cortinico

Differential Revision: D40804260

Pulled By: rshest

fbshipit-source-id: 86af14c885d6d63a0d60bb85f204d17d8757f72a
@kelset
Copy link
Contributor Author

kelset commented Oct 31, 2022

the other one got merged, so I'll close this one off

@kelset kelset closed this Oct 31, 2022
@kelset kelset deleted the kelset/clean-up-yarn-install branch October 31, 2022 10:44
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…k#35088)

Summary:
I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install.

It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier.

Also, while doing that I found a dependency that was lying there unused for 2 years so took care of it.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Fixed] - add wanted dependencies to remove yarn warnings

Pull Request resolved: facebook#35088

Test Plan:
### Before

<img width="1920" alt="Screenshot 2022-10-26 at 10 53 32" src="https://user-images.githubusercontent.com/16104054/197996489-f463be29-b35b-45cc-9d9c-2d176579fb7d.png">

### After

<img width="947" alt="Screenshot 2022-10-26 at 10 52 19" src="https://user-images.githubusercontent.com/16104054/197996505-3d60b319-006b-45ab-83bf-2f431272fdcd.png">

Reviewed By: jacdebug

Differential Revision: D40716713

Pulled By: robhogan

fbshipit-source-id: eeb95a91c6cdf37edfe868fefe4ba04aebe500ec
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…k#35122)

Summary:
This is take 2 of this facebook#35088, see this comment for why facebook#35088 (comment)

I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install.

It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Fixed] - add wanted dependencies to remove yarn warnings

Pull Request resolved: facebook#35122

Test Plan:
### Before

<img width="1920" alt="Screenshot 2022-10-26 at 10 53 32" src="https://user-images.githubusercontent.com/16104054/197996489-f463be29-b35b-45cc-9d9c-2d176579fb7d.png">

### After

<img width="947" alt="Screenshot 2022-10-26 at 10 52 19" src="https://user-images.githubusercontent.com/16104054/197996505-3d60b319-006b-45ab-83bf-2f431272fdcd.png">

Reviewed By: cortinico

Differential Revision: D40804260

Pulled By: rshest

fbshipit-source-id: 86af14c885d6d63a0d60bb85f204d17d8757f72a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants