Move react_render_debug to be consumed via prefab
#34802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This removes the old way of consuming `libreact_render_debug.so` from `Android-prebuilt.cmake` to using Prefab which is natively supported by the Android pipeline. Changelog: [Internal] [Changed] - Move `react_render_debug` to be consumed via prefab Differential Revision: D39849622 fbshipit-source-id: bef0cec923c0b9d812a8a3fa14b450879df00ff8
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39849622 |
Base commit: 8dc6bec |
Base commit: bf05df1 |
|
This pull request was successfully merged by @cortinico in 49b14cc. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#34802 This removes the old way of consuming `libreact_render_debug.so` from `Android-prebuilt.cmake` to using Prefab which is natively supported by the Android pipeline. Changelog: [Internal] [Changed] - Move `react_render_debug` to be consumed via prefab Reviewed By: cipolleschi Differential Revision: D39849622 fbshipit-source-id: 45451dfe92ecce94d1b466094baae05a75ed803f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This removes the old way of consuming
libreact_render_debug.sofromAndroid-prebuilt.cmaketo using Prefab which is natively supportedby the Android pipeline.
Changelog:
[Internal] [Changed] - Move
react_render_debugto be consumed via prefabDifferential Revision: D39849622