Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NMake generator for Hermes build on Windows #34790

Closed
wants to merge 1 commit into from
Closed

Use NMake generator for Hermes build on Windows #34790

wants to merge 1 commit into from
+1 −1

Commits on Sep 26, 2022

  1. CMake on Windows uses "Visual Studio **" generator when available. "V… 

    …isual Studio **" generators are multi-configuraiton (https://cgold.readthedocs.io/en/latest/glossary/multi-config.html),

which requires the hermes cli and hermes runtime build flavors to be compatible.
Using the "MakeFile" generator will avoid the requirement and keeps the gradle script simpler.
Please note that the "Makefile" generator is the default when only "Visual Studio Community edition" is available.
    @mganandraj
    mganandraj committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    c859347 View commit details
    Browse the repository at this point in the history