eslint config & plugin packages - prep for monorepo RFC #34581

afoxman · 2022-09-02T12:34:27Z

Summary

The monorepo RFC calls for renaming:

@react-native-community/eslint-config -> @react-native/eslint-config
@react-native-community/eslint-plugin -> @react-native/eslint-plugin

It also calls for the versions to be aligned with the rest of main -- currently 0.72.0.

Changelog

[General][Changed] - Renamed @react-native-community/eslint-config to @react-native/eslint-config v0.72.0 to align with other packages
[General][Changed] - Renamed @react-native-community/eslint-plugin to @react-native/eslint-plugin v0.72.0 to align with other packages

Test Plan

First test is to run yarn lint, and verify that output matches before and after this change.

Second test is to change the ESLint config to use the "old" packages (under @react-native-commnuity) and run yarn lint to make sure that they work as expected. This is what customers will experience, until they manually move to the new ESLint packages.

afoxman · 2022-09-02T12:35:54Z

cc @cortinico Monorepo PR

afoxman · 2022-09-02T12:51:25Z

There are some errors from CircleCI about the new packages not being in NPM yet they are referenced as dependencies in the old packages. If you'd like, I can split this up so the new packages are published first, then land that, and make a 2nd PR to update the old packages, making them point to the new ones. I didn't do that initially because I know this is going to cause a lot of internal work, and I thought 2 PRs might increase that workload.

analysis-bot · 2022-09-02T13:00:16Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,103,561	+0
android	hermes	armeabi-v7a	6,471,886	+0
android	hermes	x86	7,521,203	+0
android	hermes	x86_64	7,380,081	+0
android	jsc	arm64-v8a	8,968,399	+0
android	jsc	armeabi-v7a	7,699,505	+0
android	jsc	x86	9,030,706	+0
android	jsc	x86_64	9,508,749	+0

Base commit: e680018
Branch: main

analysis-bot · 2022-09-02T14:00:04Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: e680018
Branch: main

afoxman · 2022-09-09T17:12:35Z

cc @cipolleschi for tracking

cortinico · 2022-09-15T13:34:20Z

Hey @afoxman
Thanks for sending this over.

I've posted an update on the Monorepo effort here:

☂️ React Native Monorepo #34692

I'm not entirely sure how we want to handle this (@kelset has a stronger opinion I believe). I believe we probably don't want to keep wrapper packages for the older package names (it would be quite of an overkill, as we'll have to do it for all the packages).

I would suggest we downscale the PR to just renaming + bumping the packages.
Also, the folder renaming and the BUCK target update is not needed (we decided to defer this to streamline the work and make it easier to import those PRs).

hoxyq · 2022-11-10T15:10:03Z

Hey @afoxman,

Thanks for working on this, I am now planning to continue your work this and #34581 PRs. There are some changes that we need to introduce before merging this.

Could you please share if this is okay for you?

afoxman · 2022-11-10T17:29:44Z

Hey @afoxman,

Thanks for working on this, I am now planning to continue your work this and #34581 PRs. There are some changes that we need to introduce before merging this.

Could you please share if this is okay for you?

Hi @hoxyq, definitely! Thank you for picking this up for me and pushing the monorepo forward.

facebook-github-bot · 2022-11-23T14:20:34Z

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: The [monorepo RFC](react-native-community/discussions-and-proposals#480) calls for renaming: * `react-native-community/eslint-config` -> `react-native/eslint-config` * `react-native-community/eslint-plugin` -> `react-native/eslint-plugin` It also calls for the versions to be aligned with the rest of main -- currently `0.71.0`. ## Changelog  General Added - Added a new package `react-native/eslint-config` and migrated ESLint configuration into it from `react-native-community/eslint-config` General Added - Added a new package `react-native/eslint-plugin` and migrated ESLint plugins into it from `react-native-community/eslint-plugin` General Changed - Migrated contents of `react-native-community/eslint-config` into `react-native/eslint-config` General Changed - Migrated contents of `react-native-community/eslint-plugin` into `react-native/eslint-plugin` Pull Request resolved: facebook#34581 Test Plan: First test is to run `yarn lint`, and verify that output matches before and after this change. Second test is to change the ESLint config to use the "old" packages (under `react-native-commnuity`) and run `yarn lint` to make sure that they work as expected. This is what customers will experience, until they manually move to the new ESLint packages. Differential Revision: D41495332 Pulled By: hoxyq fbshipit-source-id: 36e756333ab0711927927c18af736c0931dbf9b4

pull-bot · 2022-11-24T13:09:54Z

PR build artifact for 7972310 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-24T13:12:45Z

PR build artifact for 7972310 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2022-11-24T13:22:58Z

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

pull-bot · 2022-11-24T23:06:08Z

PR build artifact for c657aad is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-24T23:11:11Z

PR build artifact for c657aad is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

…ch the rest of the repo.

pull-bot · 2022-11-25T10:02:30Z

PR build artifact for 2915e79 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-25T10:07:36Z

PR build artifact for 2915e79 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2022-11-25T10:24:36Z

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

react-native-bot · 2022-11-25T13:50:08Z

This pull request was successfully merged by @afoxman in 5aead70.

^{When will my fix make it into a release? | Upcoming Releases}

mm-webx · 2022-12-01T09:53:18Z

Its not working:
yarn add --dev eslint prettier @react-native/eslint-config

error An unexpected error occurred: "https://registry.npmjs.org/@react-native%2feslint-config: Not found".

kelset · 2022-12-01T10:19:51Z

@mm-webx I don't think it's expected to work yet, these new versions still need to be published. It will take time, for now you are not supposed to migrate to it. (0.71 will not use these new versions)

hoxyq · 2022-12-01T10:28:01Z

Its not working: yarn add --dev eslint prettier @react-native/eslint-config

error An unexpected error occurred: "https://registry.npmjs.org/@react-native%2feslint-config: Not found".

Hey @mm-webx, @kelset is correct, before we publish this package you can use @react-native-community/eslint-config, the instruction for it is here

Summary: The [monorepo RFC](react-native-community/discussions-and-proposals#480) calls for renaming: * `react-native-community/eslint-config` -> `react-native/eslint-config` * `react-native-community/eslint-plugin` -> `react-native/eslint-plugin` It also calls for the versions to be aligned with the rest of main -- currently `0.72.0`. ## Changelog  [General][Changed] - Renamed `react-native-community/eslint-config` to `react-native/eslint-config` v0.72.0 to align with other packages [General][Changed] - Renamed `react-native-community/eslint-plugin` to `react-native/eslint-plugin` v0.72.0 to align with other packages Pull Request resolved: facebook#34581 Test Plan: First test is to run `yarn lint`, and verify that output matches before and after this change. Second test is to change the ESLint config to use the "old" packages (under `react-native-commnuity`) and run `yarn lint` to make sure that they work as expected. This is what customers will experience, until they manually move to the new ESLint packages. Reviewed By: cortinico Differential Revision: D41520500 Pulled By: hoxyq fbshipit-source-id: a61e5ae15d5aaf11f0143a3b0257a60a03b1550b

### Summary Fixes #443 Replaced `@react-native-community/eslint-config` with `@react-native/eslint-config`. Please see the PR that changes the name on the React Native repository [here](facebook/react-native#34581) ### Test plan 1. Create a new React Native library 2. cd into the library you have created. 3. run `yarn lint` 4. Make sure linting works properly.

afoxman requested a review from hramos as a code owner September 2, 2022 12:34

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2022

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 2, 2022

kelset added the Tech: Monorepo For PRs that are related to the monorepo infra label Sep 12, 2022

cortinico mentioned this pull request Sep 14, 2022

☂️ React Native Monorepo #34692

Closed

11 tasks

hoxyq mentioned this pull request Nov 23, 2022

eslint config & plugin packages - prep for monorepo RFC (#34581) #35448

Closed

hoxyq force-pushed the monorepo branch 5 times, most recently from 977a213 to 7972310 Compare November 24, 2022 12:05

hoxyq force-pushed the monorepo branch from 7972310 to c657aad Compare November 24, 2022 22:37

Rename eslint config/plugin packages. Reset versions to 0.72.0 to mat…

2915e79

…ch the rest of the repo.

hoxyq force-pushed the monorepo branch from c657aad to 2915e79 Compare November 25, 2022 09:32

facebook-github-bot closed this in 5aead70 Nov 25, 2022

react-native-bot added the Merged This PR has been merged. label Nov 25, 2022

atlj mentioned this pull request Aug 25, 2023

feat(crnl): rn-community/eslint-config -> rn/eslint-config callstack/react-native-builder-bob#452

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eslint config & plugin packages - prep for monorepo RFC #34581

eslint config & plugin packages - prep for monorepo RFC #34581

afoxman commented Sep 2, 2022 •

edited by hoxyq

Loading

afoxman commented Sep 2, 2022

afoxman commented Sep 2, 2022

analysis-bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

afoxman commented Sep 9, 2022

cortinico commented Sep 15, 2022

hoxyq commented Nov 10, 2022

afoxman commented Nov 10, 2022

facebook-github-bot commented Nov 23, 2022

pull-bot commented Nov 24, 2022

pull-bot commented Nov 24, 2022

facebook-github-bot commented Nov 24, 2022

pull-bot commented Nov 24, 2022

pull-bot commented Nov 24, 2022

pull-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

facebook-github-bot commented Nov 25, 2022

react-native-bot commented Nov 25, 2022

mm-webx commented Dec 1, 2022

kelset commented Dec 1, 2022 •

edited

Loading

hoxyq commented Dec 1, 2022

eslint config & plugin packages - prep for monorepo RFC #34581

eslint config & plugin packages - prep for monorepo RFC #34581

Conversation

afoxman commented Sep 2, 2022 • edited by hoxyq Loading

Summary

Changelog

Test Plan

afoxman commented Sep 2, 2022

afoxman commented Sep 2, 2022

analysis-bot commented Sep 2, 2022 • edited Loading

analysis-bot commented Sep 2, 2022 • edited Loading

afoxman commented Sep 9, 2022

cortinico commented Sep 15, 2022

hoxyq commented Nov 10, 2022

afoxman commented Nov 10, 2022

facebook-github-bot commented Nov 23, 2022

pull-bot commented Nov 24, 2022

pull-bot commented Nov 24, 2022

facebook-github-bot commented Nov 24, 2022

pull-bot commented Nov 24, 2022

pull-bot commented Nov 24, 2022

pull-bot commented Nov 25, 2022

pull-bot commented Nov 25, 2022

facebook-github-bot commented Nov 25, 2022

react-native-bot commented Nov 25, 2022

mm-webx commented Dec 1, 2022

kelset commented Dec 1, 2022 • edited Loading

hoxyq commented Dec 1, 2022

afoxman commented Sep 2, 2022 •

edited by hoxyq

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

analysis-bot commented Sep 2, 2022 •

edited

Loading

kelset commented Dec 1, 2022 •

edited

Loading