-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Wrapper of InspectorPanel from View to SafeAreaView #34500
Conversation
Base commit: 361b310 |
Hi @raykle, could you please rebase your PR? |
Base commit: 81564c1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I think there are a lot of changes here unrelated to your PR, either from the rebase or potentially different lints. Can you clean this up to only your changes? Thanks!
61dd151
to
edfe547
Compare
Hi @lunaleaps, I have rebase the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, was my suggestion wrong? I think we can use es6 imports here no?
Hi @lunaleaps , Sorry about that, I'm a little not familiar with the I agree with your suggestion absolutely! |
Co-authored-by: Luna <lunaleaps@gmail.com>
8ae4898
to
1e1c1ff
Compare
modified the code and also rebased it. |
Great, thank you! |
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @raykle in afad68f. When will my fix make it into a release? | Upcoming Releases |
Summary
Currently, the
InspectorPanel
component is wrapped inView
, which is a little difficult to click the panel button when in a device with a notch screen.Changelog
[General] [Fixed] - Change Wrapper of
InspectorPanel
fromView
toSafeAreaView
Test Plan
From:
To: