Bump Gradle to 7.5.0 #34310
Closed
Bump Gradle to 7.5.0 #34310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up - #34103 - #33823 Debug/Release builds/runtime further tested on RN 0.70.0-rc.0-1 - leotm/react-native-template-new-architecture#775 - locally on `macos-13`, in CI `ubuntu-20.04` (latest, not yet beta `ubuntu-22.04`) cc @cortinico @dulmandakh
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Base commit: 1e4ebf2 |
Base commit: 1e4ebf2 |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @leotm in 5c81866. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Aug 3, 2022
Summary: ### Follow-up - #34103 - #33823 #### Debug/Release further tested on RN 0.70.0-rc.0-1 - leotm/react-native-template-new-architecture#775 - builds/runtime: locally on `macos-13` b2 - builds: in CI `ubuntu-20.04` latest (not yet beta `ubuntu-22.04`) cc cortinico dulmandakh ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Changed] - Bump Gradle to 7.5.0 Pull Request resolved: #34310 Test Plan: Everything builds and runs as expected. Reviewed By: cipolleschi Differential Revision: D38311861 Pulled By: cortinico fbshipit-source-id: c4e9e7a9052a067ffabae87204d20190ef46b351
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 8, 2022
Summary: #34310 introduced Gradle 7.5.0, but I noticed that the Gradle team actually missed to remove the `Incubating` annotation for the Java 18 support. The latest 7.5.1 is fixing that. More details can be found here: https://github.com/gradle/gradle/releases/tag/v7.5.1 ## Changelog [Android] [Changed] - Bump Gradle to 7.5.1 Pull Request resolved: #34359 Test Plan: Successfully build on a local project. I can share the actual branch if needed. Reviewed By: cipolleschi Differential Revision: D38497804 Pulled By: cortinico fbshipit-source-id: 792b83707d5b6aaf7ef29531f82a1bc9224b3204
kelset
pushed a commit
that referenced
this pull request
Aug 11, 2022
Summary: #34310 introduced Gradle 7.5.0, but I noticed that the Gradle team actually missed to remove the `Incubating` annotation for the Java 18 support. The latest 7.5.1 is fixing that. More details can be found here: https://github.com/gradle/gradle/releases/tag/v7.5.1 ## Changelog [Android] [Changed] - Bump Gradle to 7.5.1 Pull Request resolved: #34359 Test Plan: Successfully build on a local project. I can share the actual branch if needed. Reviewed By: cipolleschi Differential Revision: D38497804 Pulled By: cortinico fbshipit-source-id: 792b83707d5b6aaf7ef29531f82a1bc9224b3204
1 task
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: ### Follow-up - facebook#34103 - facebook#33823 #### Debug/Release further tested on RN 0.70.0-rc.0-1 - leotm/react-native-template-new-architecture#775 - builds/runtime: locally on `macos-13` b2 - builds: in CI `ubuntu-20.04` latest (not yet beta `ubuntu-22.04`) cc cortinico dulmandakh ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Changed] - Bump Gradle to 7.5.0 Pull Request resolved: facebook#34310 Test Plan: Everything builds and runs as expected. Reviewed By: cipolleschi Differential Revision: D38311861 Pulled By: cortinico fbshipit-source-id: c4e9e7a9052a067ffabae87204d20190ef46b351
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: facebook#34310 introduced Gradle 7.5.0, but I noticed that the Gradle team actually missed to remove the `Incubating` annotation for the Java 18 support. The latest 7.5.1 is fixing that. More details can be found here: https://github.com/gradle/gradle/releases/tag/v7.5.1 ## Changelog [Android] [Changed] - Bump Gradle to 7.5.1 Pull Request resolved: facebook#34359 Test Plan: Successfully build on a local project. I can share the actual branch if needed. Reviewed By: cipolleschi Differential Revision: D38497804 Pulled By: cortinico fbshipit-source-id: 792b83707d5b6aaf7ef29531f82a1bc9224b3204
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: ### Follow-up - facebook#34103 - facebook#33823 #### Debug/Release further tested on RN 0.70.0-rc.0-1 - leotm/react-native-template-new-architecture#775 - builds/runtime: locally on `macos-13` b2 - builds: in CI `ubuntu-20.04` latest (not yet beta `ubuntu-22.04`) cc cortinico dulmandakh ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Android] [Changed] - Bump Gradle to 7.5.0 Pull Request resolved: facebook#34310 Test Plan: Everything builds and runs as expected. Reviewed By: cipolleschi Differential Revision: D38311861 Pulled By: cortinico fbshipit-source-id: c4e9e7a9052a067ffabae87204d20190ef46b351
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: facebook#34310 introduced Gradle 7.5.0, but I noticed that the Gradle team actually missed to remove the `Incubating` annotation for the Java 18 support. The latest 7.5.1 is fixing that. More details can be found here: https://github.com/gradle/gradle/releases/tag/v7.5.1 ## Changelog [Android] [Changed] - Bump Gradle to 7.5.1 Pull Request resolved: facebook#34359 Test Plan: Successfully build on a local project. I can share the actual branch if needed. Reviewed By: cipolleschi Differential Revision: D38497804 Pulled By: cortinico fbshipit-source-id: 792b83707d5b6aaf7ef29531f82a1bc9224b3204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up
Debug/Release further tested on RN 0.70.0-rc.0-1
macos-13b2ubuntu-20.04latest (not yet betaubuntu-22.04)cc @cortinico @dulmandakh
Changelog
[Android] [Changed] - Bump Gradle to 7.5.0
Test Plan
Everything builds and runs as expected.