Response headers to image - iOS

[frags51]

Summary

Please see this issue #33034 for details on the problem solved by this PR.

Changelog

[CATEGORY] [TYPE] - Message
[ios] [changed] - HTTP Response headers added to the error object passed to JS code.

Test Plan

Tested:
(All tests done on images in rn-tester app, which is a part of this repo)

1. onError method in case image has an HTTP Error
2. onError method in case of non http error (DNS error)
3. Successful image load

[facebook-github-bot]

Hi @frags51!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,782,640	+0
android	hermes	armeabi-v7a	7,172,350	+0
android	hermes	x86	8,093,283	+0
android	hermes	x86_64	8,069,317	+0
android	jsc	arm64-v8a	9,649,489	+0
android	jsc	armeabi-v7a	8,408,181	+0
android	jsc	x86	9,600,998	+0
android	jsc	x86_64	10,194,061	+0

Base commit: 68e4e91
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 68e4e91
Branch: main

[frags51]

Can someone help me with why the tests on Windows/npm-package build are failing?

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[cipolleschi]

Hi @frags51, thank you for the PR.

For what concerns the CI tests failing, could you rebase this PR against main? That trunk is stable and your diff should not influence those tests.

I also left a few comment to improve readability and to make sure it will work internally in Meta as well.

[frags51]

Some tests seem to be failing again :3

[frags51]

Hi @cipolleschi Could you please review this PR?

[cipolleschi]

Thanks for this PR, it looks good to me.

As for the test, could you rebase and see if it fixes? Becuase I see the CI green on main! :D

(Sorry for the delay, I was on vacation last week!)

[frags51]

Hi @cipolleschi Thanks for the review! Kindle merge the PR. I have rebased to latest main branch

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by Supreet Singh in 9eb2826.

^{When will my fix make it into a release? | Upcoming Releases}