Unify platform behavior of processTransform

[acoates-ms]

Currently both iOS and Android send over the list of transforms as an array. But there is an if statement that causes other platforms to get a matrix. This prevents other platforms from being able to use the fabric ViewProps class and the conversion functions as they exist in core, as those expect the transforms to be an array.

Summary

Stop special casing iOS and android. - Which will allow for example Windows to be able to share more fabric code.

Changelog

[Internal] [Changed] - All platforms should get transform sent to native as an array of transform operations instead of a matrix

Test Plan

Similar change made in react-native-windows.
microsoft/react-native-windows#9797

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,826,119	-5,000
android	hermes	armeabi-v7a	7,216,983	-4,998
android	hermes	x86	8,138,731	-5,004
android	hermes	x86_64	8,117,247	-4,996
android	jsc	arm64-v8a	9,704,212	-2,642
android	jsc	armeabi-v7a	8,458,887	-2,633
android	jsc	x86	9,654,774	-2,643
android	jsc	x86_64	10,253,240	-2,643

Base commit: a21a1f8
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: a21a1f8
Branch: main

[elicwhite]

Does React Native Web need this code?

[acoates-ms]

Ah, Is that the other platform? Was trying to work out why this if existed at all. -- Shouldn't that be something that react-native-web can change? This will likely be a change for many out of tree platforms. But I'd rather have the default match ios/android, and platforms can fork this code back if they want to maintain the old behavior or update their projection to native to handle the new format. As it stands, we have to fork the code to align with core, which seems like the wrong way around.

[ecreeth]

Does React Native Web need this code?

I couldn't find anything related in the react native web repository. They have their own implementation of the StyleSheet API. Much more now in the new version that is about to be deployed in necolas/react-native-web#2248

[ecreeth]

cc @cortinico

[cortinico]

Can we get a rebase + have the CI green before we import/merge this @acoates-ms ?

[acoates-ms]

@cortinico - Done.

[ecreeth]

It would be great if you could also remove the MatrixMath.js helper, it was only used by the processTransform.js

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @acoates-ms in ee33385.

^{When will my fix make it into a release? | Upcoming Releases}