Setup multi-variant publishing for React Native Android #33539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35289444 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D35289444 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 4, 2022
Summary: Pull Request resolved: facebook#33539 As we now provide `hermes-executor-debug` OR `hermes-executor-release` based on which version of RN we're building, we need to provide a variant aware AAR. Changelog: [Internal] [Changed] - Setup multi-variant publishing for React Native Android Differential Revision: D35289444 fbshipit-source-id: 7f6dc5ffafdf14915df51d642bf9e67e84a24413
cortinico
force-pushed
the
export-D35289444
branch
from
5f0a53d
to
7cf48d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35289444 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 4, 2022
Summary: Pull Request resolved: facebook#33539 As we now provide `hermes-executor-debug` OR `hermes-executor-release` based on which version of RN we're building, we need to provide a variant aware AAR. Changelog: [Internal] [Changed] - Setup multi-variant publishing for React Native Android Differential Revision: D35289444 fbshipit-source-id: 5e8bdc3b1313d16fd1e5df08fb6e64f38f9f3691
cortinico
force-pushed
the
export-D35289444
branch
from
7cf48d6
to
0241003
Compare
Base commit: 6e5cefe |
Base commit: 6e5cefe |
|
This pull request was exported from Phabricator. Differential Revision: D35289444 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 4, 2022
Summary: Pull Request resolved: facebook#33539 As we now provide `hermes-executor-debug` OR `hermes-executor-release` based on which version of RN we're building, we need to provide a variant aware AAR. Changelog: [Internal] [Changed] - Setup multi-variant publishing for React Native Android Differential Revision: D35289444 fbshipit-source-id: b252123f31d7cf2f322ab3f713e5c32ac6ae4385
cortinico
force-pushed
the
export-D35289444
branch
from
0241003
to
0c026fd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35289444 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 4, 2022
Summary: Pull Request resolved: facebook#33539 As we now provide `hermes-executor-debug` OR `hermes-executor-release` based on which version of RN we're building, we need to provide a variant aware AAR. Changelog: [Internal] [Changed] - Setup multi-variant publishing for React Native Android Differential Revision: D35289444 fbshipit-source-id: d9a73959e098860191590b4949b7d92227b3c45f
cortinico
force-pushed
the
export-D35289444
branch
from
0c026fd
to
363db91
Compare
Summary: Pull Request resolved: facebook#33539 As we now provide `hermes-executor-debug` OR `hermes-executor-release` based on which version of RN we're building, we need to provide a variant aware AAR. Changelog: [Internal] [Changed] - Setup multi-variant publishing for React Native Android Reviewed By: ShikaSD Differential Revision: D35289444 fbshipit-source-id: 01f0098526a391569d7cd86bc8887729f5d94fdb
|
This pull request was exported from Phabricator. Differential Revision: D35289444 |
cortinico
force-pushed
the
export-D35289444
branch
from
363db91
to
d8712b6
Compare
|
This pull request was successfully merged by @cortinico in 1e51ac2. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33539 As we now provide `hermes-executor-debug` OR `hermes-executor-release` based on which version of RN we're building, we need to provide a variant aware AAR. Changelog: [Internal] [Changed] - Setup multi-variant publishing for React Native Android Reviewed By: ShikaSD Differential Revision: D35289444 fbshipit-source-id: ffccd2089dc2eb50ea8c08ed10d8fd9816f9efb7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As we now provide
hermes-executor-debugORhermes-executor-releasebased on which version of RN we're building, we need to provide a variant aware AAR.Changelog:
[Internal] [Changed] - Setup multi-variant publishing for React Native Android
Differential Revision: D35289444