Replaced windowsAwareYarn with windowsAwareCommandLine for node calls #33530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 16397e0 |
It is not necessary to call node via yarn. Instead with this commit node is called directly (windows aware). This enables builds on systems that don't have yarn installed.
Base commit: 16397e0 |
|
Thanks for addressing this @danilobuerger 🙏 We need to find a way to ship a point release for RGP but we'll make sure this is included 👍 |
|
This pull request was successfully merged by @danilobuerger in d5da70e. When will my fix make it into a release? | Upcoming Releases |
cortinico
added
the
Type: New Architecture
fortmarek
pushed a commit
that referenced
this pull request
Apr 13, 2022
…#33530) Summary: It is not necessary to call node via yarn. Instead with this commit node is called directly (windows aware). This enables builds on systems that don't have yarn installed. Fixes #33525 ## Changelog [Android] [Fixed] - Don't require yarn for codegen tasks Pull Request resolved: #33530 Test Plan: 1. react-native init test 2. cd test 3. enable newArchEnabled=true (gradle.properties) 4. enable enableHermes: true (build.gradle) 5. react-native run-android (when the yarn is not installed on the system) (I have not tested or verified if this works on windows build machines) Reviewed By: sshic Differential Revision: D35279376 Pulled By: cortinico fbshipit-source-id: 430e4a7bcdec7d5377efac747f6b935d634451cc
This was referenced Nov 14, 2022
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
…facebook#33530) Summary: It is not necessary to call node via yarn. Instead with this commit node is called directly (windows aware). This enables builds on systems that don't have yarn installed. Fixes facebook#33525 ## Changelog [Android] [Fixed] - Don't require yarn for codegen tasks Pull Request resolved: facebook#33530 Test Plan: 1. react-native init test 2. cd test 3. enable newArchEnabled=true (gradle.properties) 4. enable enableHermes: true (build.gradle) 5. react-native run-android (when the yarn is not installed on the system) (I have not tested or verified if this works on windows build machines) Reviewed By: sshic Differential Revision: D35279376 Pulled By: cortinico fbshipit-source-id: 430e4a7bcdec7d5377efac747f6b935d634451cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It is not necessary to call node via yarn. Instead with this commit node is called directly (windows aware). This enables builds on systems that don't have yarn installed.
Fixes #33525
Changelog
[Android] [Fixed] - Don't require yarn for codegen tasks
Test Plan
(I have not tested or verified if this works on windows build machines)