Remove iOS 11 deprecation warnings around SafeArea #32851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
ken0nek
commented
Jan 8, 2022
| NSStringFromUIEdgeInsets(_currentSafeAreaInsets)]; | ||
| } | ||
|
|
||
| - (BOOL)isSupportedByOS | ||
| { | ||
| return [self respondsToSelector:@selector(safeAreaInsets)]; |
| - (UIEdgeInsets)safeAreaInsetsIfSupportedAndEnabled | ||
| { | ||
| if (self.isSupportedByOS) { | ||
| return self.safeAreaInsets; |
There was a problem hiding this comment.
We can delete this property because safeAreaInsetsIfSupportedAndEnabled always returns self.safeAreaInsets.
| return self.emulateUnlessSupported ? self.emulatedSafeAreaInsets : UIEdgeInsetsZero; | ||
| } | ||
|
|
||
| - (UIEdgeInsets)emulatedSafeAreaInsets |
There was a problem hiding this comment.
We don't this fallback any longer.
| { | ||
| [super layoutSubviews]; | ||
|
|
||
| if (!self.isSupportedByOS && self.emulateUnlessSupported) { |
There was a problem hiding this comment.
This never called because isSupportedByOS is always true/YES
Base commit: 46ab59c |
Base commit: 46ab59c |
|
@sota000 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
sota000
suggested changes
Jan 20, 2022
Comment on lines
33
to
38
| exported = React.forwardRef< | ||
| ViewProps, | ||
| React.ElementRef<HostComponent<mixed>>, | ||
| >(function SafeAreaView(props, forwardedRef) { | ||
| return <View {...props} ref={forwardedRef} />; | ||
| }); |
There was a problem hiding this comment.
Can this be simplified to this?
Suggested change
| exported = React.forwardRef< | |
| ViewProps, | |
| React.ElementRef<HostComponent<mixed>>, | |
| >(function SafeAreaView(props, forwardedRef) { | |
| return <View {...props} ref={forwardedRef} />; | |
| }); | |
| exported = View; | |
| }); |
Comment on lines
43
to
48
| exported = React.forwardRef< | ||
| ViewProps, | ||
| React.ElementRef<HostComponent<mixed>>, | ||
| >(function SafeAreaView(props, forwardedRef) { | ||
| return <RCTSafeAreaViewNativeComponent {...props} ref={forwardedRef} />; | ||
| }); |
There was a problem hiding this comment.
Can this be simplified to this?
Suggested change
| exported = React.forwardRef< | |
| ViewProps, | |
| React.ElementRef<HostComponent<mixed>>, | |
| >(function SafeAreaView(props, forwardedRef) { | |
| return <RCTSafeAreaViewNativeComponent {...props} ref={forwardedRef} />; | |
| }); | |
| exported = require('./RCTSafeAreaViewNativeComponent').default; | |
| }); |
There was a problem hiding this comment.
Thank you for the feedback!
ken0nek
force-pushed
the
work/ios-11-availability-safe-area
branch
3 times, most recently
from
24f43ae
to
82a4906
Compare
|
@sota000 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ken0nek
force-pushed
the
work/ios-11-availability-safe-area
branch
from
82a4906
to
786d4a4
Compare
|
@sota000 Rebased, and all checks have passed 👍 |
|
This pull request was successfully merged by @ken0nek in c73e021. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
Summary: I removed the code checking iOS 12 availability because the iOS minimum deployment target is now iOS 12.4 after these commits (982ca30, c71e6ef). My previous pull requests regarding iOS 11 * [Remove iOS 11 version check by ken0nek · Pull Request #32151 · facebook/react-native](#32151) * [Remove iOS 11 availability check by ken0nek · Pull Request #32488 · facebook/react-native](#32488) * [Remove iOS 11 deprecation warnings around SafeArea by ken0nek · Pull Request #32851 · facebook/react-native](#32851) ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Changed] - Remove iOS 12 availability check Pull Request resolved: #33460 Reviewed By: NickGerleman Differential Revision: D35021632 Pulled By: javache fbshipit-source-id: bf85d44874a2c10cb345d33df7c9e4789312a7cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't have to check or emulate the safe area for iOS 11 above. I deleted the unnecessary check for the safe area.
This is a continuation pull request of these iOS 11 availability check.
topLayoutGuide,bottomLayoutGuide)RCTSafeAreaViewemulateUnlessSupportedpropertyDocs PR: facebook/react-native-website#2919
Changelog
[iOS] [Removed] - Remove
emulateUnlessSupportedTest Plan