Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add turbo module support in the default app template #32752

Closed
wants to merge 2 commits into from

Conversation

sota000
Copy link
Contributor

@sota000 sota000 commented Dec 14, 2021

Summary: Changelog: [internal] Add an optional support for Turbomodule. Define RCT_TM_FABRIC_ENABLED to enable the new architecture.

Reviewed By: philIip

Differential Revision: D33052777

Summary:
Changelog: [internal] Move initital setups in AppDelegate to util classes.

This will make it easy to apply the new architecture changes in the future.

Differential Revision: D33051517

fbshipit-source-id: 12f3647077b09c7aac6bbe0e876be8d2a18368ba
Summary: Changelog: [internal] Add an optional support for Turbomodule. Define RCT_TM_FABRIC_ENABLED to enable the new architecture.

Reviewed By: philIip

Differential Revision: D33052777

fbshipit-source-id: 139ddd6bb985fed40ef9e5ed302247d99b293824
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 14, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D33052777

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 24e07bc
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,293,042 +0
android hermes armeabi-v7a 7,623,655 +0
android hermes x86 8,763,620 +0
android hermes x86_64 8,702,530 +0
android jsc arm64-v8a 9,681,450 +0
android jsc armeabi-v7a 8,668,758 +0
android jsc x86 9,637,541 +0
android jsc x86_64 10,234,044 +0

Base commit: 24e07bc
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @sota000 in 8ec0e69.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants