Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: export packager environment variables #32666

Closed
wants to merge 1 commit into from
Closed

CLI: export packager environment variables #32666

wants to merge 1 commit into from

Conversation

enniel
Copy link
Contributor

@enniel enniel commented Nov 26, 2021

Summary

Custom metro port not working without exporting variables from .packager.env

Changelog

[General] [Fixed] - Fix support for custom port

Test Plan

run react-native run-android --port=8082 and react-native run-ios --port=8082

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 26, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: e89d494
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,519,503 +0
android hermes armeabi-v7a 7,823,753 +0
android hermes x86 8,989,815 +0
android hermes x86_64 8,935,919 +0
android jsc arm64-v8a 9,832,984 +0
android jsc armeabi-v7a 8,798,731 +0
android jsc x86 9,783,625 +0
android jsc x86_64 10,386,508 +0

Base commit: e89d494
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 29, 2021
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in b399c2e.

nawbc pushed a commit to NawbExplorer/react-native that referenced this pull request Dec 7, 2021
Summary:
Custom metro port not working without exporting variables from `.packager.env`

## Changelog

[General] [Fixed] - Fix support for custom port

Pull Request resolved: facebook#32666

Test Plan: run `react-native run-android --port=8082` and `react-native run-ios --port=8082`

Reviewed By: yungsters

Differential Revision: D32694233

Pulled By: cortinico

fbshipit-source-id: 42e803d56b83608024b901d2a3024733ed7099b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants