Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make CLI error message more descriptive #32593

Closed
wants to merge 1 commit into from
Closed

chore: make CLI error message more descriptive #32593

wants to merge 1 commit into from

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Nov 14, 2021

Summary

motivation: I have a custom setup and needed to provide react.cliPath. I mistakenly provided path to @react-native-community/cli which resulted into JS bundle not being generated. This error message provides a little more detail.

Changelog

[General] [Changed] - Improved error message in react.gradle

Test Plan

I guess it's not needed in this case

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 14, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a507998
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,477,943 +0
android hermes armeabi-v7a 7,775,189 +0
android hermes x86 8,947,093 +0
android hermes x86_64 8,894,003 +0
android jsc arm64-v8a 9,791,890 +0
android jsc armeabi-v7a 8,752,625 +0
android jsc x86 9,740,716 +0
android jsc x86_64 10,341,569 +0

Base commit: a507998
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

That's great. Don't you mind updating the message also here:

react-native/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/PathUtils.kt

Lines 94 to 96 in d314d1f

error(
"Couldn't determine CLI location. " +
"Please set `project.react.cliPath` to the path of the react-native cli.js")

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 15, 2021
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 7366a86.

vonovak added a commit to vonovak/react-native that referenced this pull request Nov 15, 2021
@vonovak
chore: make CLI error message more descriptive pt2
23661c0 
follow up to facebook#32593
@vonovak vonovak mentioned this pull request Nov 15, 2021
Closed
facebook-github-bot pushed a commit that referenced this pull request Nov 17, 2021
@vonovak @facebook-github-bot
chore: make CLI error message more descriptive pt2 (#32598)
aabf7f7 
Summary:
follow up to #32593

Changelog:
[Internal] [Changed] - chore: make CLI error message more descriptive pt2

Pull Request resolved: #32598

Reviewed By: feedthejim

Differential Revision: D32430833

Pulled By: cortinico

fbshipit-source-id: 0930c42f942653e912ffe887ae7fed6cdab8a255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vonovak @analysis-bot @facebook-github-bot @cortinico