Fix Android border positioning regression

[oblador]

Summary

#29099 introduced a regression where non-rounded borders on Android would render partly outside of the bounds of the view as I reported in #32393. This PR addresses that by rendering the borders completely inside the view like it works on iOS, previous version of RN and for rounded corners.

Changelog

[Android] [Fixed] - Fix Android border positioning regression

Test Plan

Rendering the following code (as reported in the issue) in the RN Tester app:

<View
  style={{
    aspectRatio: 1,
    backgroundColor: 'green',
    borderWidth: 8,
    borderColor: 'black',
    borderStyle: 'dashed',
  }}
/>

Before	After

[pull-bot]

PR build artifact for 5a01e8f is ready.
To use, download tarball from this CircleCI job then run yarn add <path to tarball> in your React Native project.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,717,953	-33
android	hermes	armeabi-v7a	7,246,018	-34
android	hermes	x86	8,137,536	-34
android	hermes	x86_64	8,103,027	-35
android	jsc	arm64-v8a	9,637,144	-86
android	jsc	armeabi-v7a	8,552,739	-81
android	jsc	x86	9,651,010	-86
android	jsc	x86_64	10,260,183	-87

Base commit: 8ba4a2f

[mikehardy]

One would expect that with a .java only change, the iOS CI failures are not related.
This looks great!

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[yungsters]

Sweet. Thanks for finding and fixing this, @oblador.

Looks like this regression was introduced by cb0e1d6, tagging @fabriziobertoglio1987 as a heads up.

[facebook-github-bot]

@lunaleaps merged this pull request in d1a33cd.

[oblador]

Thanks for the super quick resolution 🙏 👏