Upgrade folly to fix NDK 21 build issue #31802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
Contributor
|
@dulmandakh you may interest for this, from my previous work to verify the folly fix. |
|
@ShikaSD please review and merge |
Base commit: c06d8d0 |
Base commit: c06d8d0 |
|
@Kudo thanks 👍 |
|
@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade folly for the facebook/folly#1593 fix for NDK 21 failure
Changelog
[Android] [Changed] - Upgrade folly to 2021.06.28.00
Test Plan
./gradlew :ReactAndroid:installArchives./gradlew packages:rn-tester:android:app:installJscRelease./gradlew packages:rn-tester:android:app:installHermesRelease