Remove defaultProps from FlatList

[daschaa]

Summary

Issue #31602. Remove defaultProps from FlatList.

Changelog

[JavaScript] [Changed] - Remove defaultProps from FlatList

Test Plan

All test for FlatList pass.

124162098-6dfe4380-da9e-11eb-9fd6-ab47820aebfa.mov

[analysis-bot]

Code analysis results:

• eslint found some issues. Run yarn lint --fix to automatically fix problems.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: fa0518d

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	9,120,606	+17
android	hermes	armeabi-v7a	8,646,648	+22
android	hermes	x86	9,559,952	+18
android	hermes	x86_64	9,526,134	+25
android	jsc	arm64-v8a	10,763,210	+48
android	jsc	armeabi-v7a	9,680,503	+38
android	jsc	x86	10,797,960	+45
android	jsc	x86_64	11,405,635	+40

Base commit: fa0518d

[daschaa]

@lunaleaps Could you review the pull request? I would be very grateful 😊

[lunaleaps]

Looks good, thank you so much for working on this! Small comments about adding more documentation in the props about defaults. Let me know if you want to add those or I can add them on land. @joxw1 Let me know your call and I'll import :)

[daschaa]

Looks good, thank you so much for working on this! Small comments about adding more documentation in the props about defaults. Let me know if you want to add those or I can add them on land. @joxw1 Let me know your call and I'll import :)

I can add the documentation, no problem 😊

One thing that came up to my mind while reviewing my changes: Should I introduce a constant for all the {numColumns = 1 } assignments? Something like {numColumns = DEFAULT_NUM_COLUMNS} ? What is your opinion on that @lunaleaps ? And thank you very much for your review! 🚀

[lunaleaps]

One thing that came up to my mind while reviewing my changes: Should I introduce a constant for all the {numColumns = 1 } assignments? Something like {numColumns = DEFAULT_NUM_COLUMNS} ? What is your opinion on that @lunaleaps ? And thank you very much for your review! 🚀

That's a good idea! I think the concern is that someone introduces a new read of the prop and doesn't set a default value. I think using a constant like that could help make it clearer if they miss it. In other work I've also created a dedicated accessor function like getNumColumnsOrDefault which serves a similar purpose.

[daschaa]

One thing that came up to my mind while reviewing my changes: Should I introduce a constant for all the {numColumns = 1 } assignments? Something like {numColumns = DEFAULT_NUM_COLUMNS} ? What is your opinion on that @lunaleaps ? And thank you very much for your review! 🚀

That's a good idea! I think the concern is that someone introduces a new read of the prop and doesn't set a default value. I think using a constant like that could help make it clearer if they miss it. In other work I've also created a dedicated accessor function like getNumColumnsOrDefault which serves a similar purpose.

Done! For the naming of the accessor functions I followed the VirtualizedList class, where the accessor functions have the variable name as prefix (e.g. horizontalOrDefault(...)). Thank you very much for the nice suggestion 😊

@lunaleaps If everything fits now, will you take over the merge?

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[daschaa]

@lunaleaps Any updates on this?

[facebook-github-bot]

@lunaleaps merged this pull request in 7d5895d.