Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid encoding local path in Podfile.lock #31688

Closed
wants to merge 1 commit into from
Closed

Avoid encoding local path in Podfile.lock #31688

wants to merge 1 commit into from

Conversation

omnikron
Copy link
Contributor

@omnikron omnikron commented Jun 9, 2021

Summary

This PR backports bdfe2a5 (already in master) to 0.64-stable, so that this fix can be included in 0.64.3, see discussion: react-native-community/releases#232. There were some conflicts applying the original commit to 0.64-stable, this commit by @danilobuerger from their fork feastr@d9f7770 has resolved those.

Changelog

  • Avoid encoding local path in Podfile.lock

Test Plan

  1. Run pod install and commit Podfile.lock
  2. Move project somewhere else
  3. Run pod install again. It should not fail.

@hramos @omnikron
Avoid encoding local path in Podfile.lock
551caf3 
Summary:
The `SPEC CHECKSUM` for `FBReactNativeSpec` in `packages/rn-tester/Podfile.lock` and in standalone apps's `ios/Podfile.lock` varies between development machines. This is caused by local paths in the output of `pod ipc spec FBReactNativeSpec.podspec`, such as `output_files` and `prepare_command`. This causes the Podfile.lock to constantly change when pod install is run on different developers' machines.

The codegen script and CocoaPods configuration have been updated to use relative paths.

Closes #31193

Changelog: [Internal] [Codegen] Avoid encoding local path in Podfile.lock

Reviewed By: fkgozali

Differential Revision: D27754337

fbshipit-source-id: 2f5607d4e1ce21489f28f394cb852c36cace6798
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2021
@omnikron omnikron mentioned this pull request Jun 9, 2021
Closed
@pull-bot
Copy link

pull-bot commented Jun 9, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 551caf3

@omnikron
Copy link
Contributor Author

0.64 is no longer being patched so this is no longer necessary.

@omnikron omnikron closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omnikron @pull-bot @facebook-github-bot @hramos