-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump CLI to ^5.0.1 #31682
chore: Bump CLI to ^5.0.1 #31682
Conversation
b48e955
to
1da1e03
Compare
|
@thymikee Do you have any insight to the circleci failures? |
@lunaleaps not quite. This would need a rebase to be sure |
Do we still need this PR? It's against the 64 branch, does it mean that we need to do a new patch release for 64? |
Technically this CLI bump is within the semver range, I don't have a strong opinion here. |
@lunaleaps around Xcode 12.5 you can find more info here -> #31480 I don't have strong feelings either for a new patch release for 0.64; there was some folks that wanted it react-native-community/releases#232 so maybe we merge this then do a 0.64 patch as a "pairing experience" to teach you/some FB folks on the process in a learn by doing fashion? |
From discussion on react-native-community/releases#232, we won't be releasing a 0.64 patch. cc @kelset Closing this for now, please re-open with concerns |
Summary
Upgrade RN CLI to stable 5.0.1. The biggest thing it fixes is selecting device/simulator on Xcode 12.5.
Targeting
0.64-stable
branch, as master is on v6 already. cc @kelset @grabbouRelease notes: https://github.com/react-native-community/cli/releases/tag/v5.0.1
Changelog
[General] [Fix] - Bump CLI to ^5.0.1
Test Plan