Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump CLI to ^5.0.1 #31682

Closed
wants to merge 1 commit into from

Conversation

thymikee
Copy link
Contributor

@thymikee thymikee commented Jun 8, 2021

Summary

Upgrade RN CLI to stable 5.0.1. The biggest thing it fixes is selecting device/simulator on Xcode 12.5.
Targeting 0.64-stable branch, as master is on v6 already. cc @kelset @grabbou

Release notes: https://github.com/react-native-community/cli/releases/tag/v5.0.1

Changelog

[General] [Fix] - Bump CLI to ^5.0.1

Test Plan

@thymikee thymikee requested a review from hramos as a code owner June 8, 2021 09:44
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Jun 8, 2021
@thymikee thymikee force-pushed the chore/cli-5-stable branch from b48e955 to 1da1e03 Compare June 8, 2021 09:45
@pull-bot
Copy link

pull-bot commented Jun 8, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 1da1e03

@lunaleaps
Copy link
Contributor

@thymikee Do you have any insight to the circleci failures?

@thymikee
Copy link
Contributor Author

thymikee commented Aug 4, 2021

@lunaleaps not quite. This would need a rebase to be sure

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels Aug 4, 2021
@kelset
Copy link
Contributor

kelset commented Aug 4, 2021

Do we still need this PR? It's against the 64 branch, does it mean that we need to do a new patch release for 64?

@thymikee
Copy link
Contributor Author

thymikee commented Aug 4, 2021

Technically this CLI bump is within the semver range, I don't have a strong opinion here.

@lunaleaps
Copy link
Contributor

lunaleaps commented Aug 4, 2021

Have there been raised issues with Xcode 12.5 for 0.64? I guess we can merge this regardless and if someone wants to drive a patch release, then sure?
What do you guys think @kelset, @thymikee? Just trying to get a resolution on this PR.

@kelset
Copy link
Contributor

kelset commented Aug 5, 2021

@lunaleaps around Xcode 12.5 you can find more info here -> #31480

I don't have strong feelings either for a new patch release for 0.64; there was some folks that wanted it react-native-community/releases#232 so maybe we merge this then do a 0.64 patch as a "pairing experience" to teach you/some FB folks on the process in a learn by doing fashion?

@lunaleaps
Copy link
Contributor

From discussion on react-native-community/releases#232, we won't be releasing a 0.64 patch. cc @kelset

Closing this for now, please re-open with concerns

@lunaleaps lunaleaps closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Needs: Attention Issues where the author has responded to feedback. Needs: Author Feedback p: Callstack Partner: Callstack Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants