Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN project wide Kotlin version #31645

Closed
wants to merge 1 commit into from

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Jun 2, 2021

Summary

This PR sets project wide Kotlin version to 1.4.21, supported in Buck https://github.com/facebook/buck/tree/dev/third-party/java/kotlin.

We had to specify version for both kotlin-dsl and kotlin('jvm') plugins to remove version mismatch warnings in react-native-gradle-plugin. Also I expect more Kotlin code in RN, so instead of specifying version for each sub-project it's better to have project wide setting.

We don't need to load Kotlin in react-native-gradle-plugin because Kotlin is available RN project wide.

Changelog

[Internal] [Changed] - Project wide Kotlin version set to 1.4.21

Test Plan

Everything works as expected, no visible change for developers.

@facebook-github-bot facebook-github-bot added Contributor A React Native contributor. CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 2, 2021
@dulmandakh
Copy link
Contributor Author

@ShikaSD please review and merge

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 286fac5

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,239,992 +0
android hermes armeabi-v7a 8,749,684 +0
android hermes x86 9,702,602 +0
android hermes x86_64 9,667,479 +0
android jsc arm64-v8a 10,885,297 +0
android jsc armeabi-v7a 9,786,263 +0
android jsc x86 10,943,305 +0
android jsc x86_64 11,549,705 +0

Base commit: 286fac5

@facebook-github-bot
Copy link
Contributor

@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ShikaSD merged this pull request in 9a5e226.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants