Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] fbjni version to 0.2.2 #31191

Closed
wants to merge 1 commit into from

Conversation

IvanKobzarev
Copy link
Contributor

@IvanKobzarev IvanKobzarev commented Mar 18, 2021

android fbjni dependency bump to 0.2.2

Summary

The motivation is to address pytorch/pytorch#34682 that pytorch_android and react-native use different versions of fbjni with the same name libfbjni.so

In case of loading 0.0.2 version it is missing functions in binary

Fbjni is not changing much, that's why this will solve that problem for a long time (Until fbjni changed and versions will not be aligned)

Changelog

[Android][Added] fbjni version bump to 0.0.3

Test Plan

Automated (relying on the test suite) and manual testing.

@facebook-github-bot facebook-github-bot added p: Facebook Partner: Facebook Partner CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 18, 2021
@analysis-bot
Copy link

analysis-bot commented Mar 18, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a15a46c

@IvanKobzarev IvanKobzarev changed the title [android] fbjni version to 0.0.3 [android] fbjni version to 0.2.0 Mar 22, 2021
@IvanKobzarev IvanKobzarev force-pushed the android_fbjni_003 branch 3 times, most recently from e3e1782 to 049761a Compare March 22, 2021 18:13
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,851,864 -99,835
android hermes armeabi-v7a 8,358,703 -81,868
android hermes x86 9,341,726 -103,339
android hermes x86_64 9,281,450 -106,346
android jsc arm64-v8a 10,584,135 -99,827
android jsc armeabi-v7a 10,074,070 -81,872
android jsc x86 10,635,503 -103,325
android jsc x86_64 11,215,475 -106,349

Base commit: 866bf5f

@IvanKobzarev IvanKobzarev changed the title [android] fbjni version to 0.2.0 [android] fbjni version to 0.0.4 Mar 22, 2021
@IvanKobzarev IvanKobzarev changed the title [android] fbjni version to 0.0.4 [android] fbjni version to 0.2.2 Mar 25, 2021
@facebook-github-bot
Copy link
Contributor

@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@IvanKobzarev merged this pull request in 24f9f75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants