nested text onPress not working on last character

[fabOnReact]

Summary

This issue fixes #22747 nested text does not allow you to press on the last character.

The method reactTagForTouch filters touches based on coordinates x and y. Nested Texts are converted into Spans on Android

react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactBaseTextShadowNode.java

Lines 111 to 112 in 28fb41a

	for (int i = 0, length = textShadowNode.getChildCount(); i < length; i++) {
	ReactShadowNode child = textShadowNode.getChildAt(i);

https://developer.android.com/guide/topics/text/spans

reactTagForTouch iterates over the span and triggers the onPress handler if the x,y coordinates correspond to one of the span characters.

Changelog

[Android] [Fixed] - Nested Text Android onPress does not work with last character

Test Plan

This changes fix the Java API which can not be tested as explained in commit 709a441
The java TextTest was excluded from the test suite in commit 709a441 as they need the Yoga libraries to run

TEST - Clicking on the last letter triggers the callback

Clicking on the last letter does not invoke the onPress callback (in this case a console.warn)

BEFORE

Clicking on the last letter does invoke the onPress callback (in this case a console.warn)

AFTER

TEST - Adding and removing Text

2021-02-10.17-41-44.mp4

TEST - Different type of languages

2021-02-10.17-44-20.mp4

TEST - Testing other Examples that use onPress handler

2021-02-10.17-46-24.mp4

TEST - Text with Inline Images

Inline View	Inline Image is clipped

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 4324ca8

[fabOnReact]

I am asking myself why it did work on non-nested Text.
I need to find the reason spanEnd reaches the index value on the last characted when the Text is nested in another Text

[fabOnReact]

The issue was not experienced on non-nested text as normal Text will not generate Spans. Spans are generated by nested Text react tags

[fabOnReact]

I investigated the current failures in the CI and they not are related to this pr. I tried but could not find a solution to the failures, which relate to AppCompat (Error inflating class com.android.internal.widget.ActionBarContextView)

Unluckily the Java Unit Test for ReactTextTest were disabled for an issue with Yoga linking t14964130

react-native/ReactAndroid/src/test/java/com/facebook/react/views/BUCK

Lines 5 to 6 in b113f66

	# TODO Disabled temporarily until Yoga linking is fixed t14964130
	# srcs = glob(['**/*.java']),

Related Discussions #11570 #11511 (comment)

I will invest my time writing Java tests for other functionalities as this seems pretty hard issues to solve. Thanks

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,891,081	+4
android	hermes	armeabi-v7a	8,394,800	+1
android	hermes	x86	9,380,336	+6
android	hermes	x86_64	9,323,049	-9
android	jsc	arm64-v8a	10,341,057	+6
android	jsc	armeabi-v7a	9,827,875	-1
android	jsc	x86	10,391,813	+0
android	jsc	x86_64	10,974,795	+4

Base commit: 4324ca8

[parveen-bhatia]

Facing same issue. What are the plans to move it forward ?

Thanks @fabriziobertoglio1987 for this. This patch is working for us.

[facebook-github-bot]

@charlesbdudley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.