Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot working Modal's onDismiss #30688

Closed
wants to merge 1 commit into from

Commits on Jan 5, 2021

  1. Fix cannot working Modal's onDismiss

    Summary:
    Fixes: facebook#29455
    
    Modal's onDismiss is not called on iOS.
    This issue occurred the commit facebook@bd2b7d6 and was fixed the commit facebook@27a3248.
    However, the master and stable-0.63 branches do not have this modified commit applied to them.
    
    <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
    https://github.com/facebook/react-native/wiki/Changelog
    -->
    
    [iOS] [Fixed] - Modal's onDismiss prop will now be called successfully.
    
    Test Plan:
    Tested on iOS with this change:
    
    1. Set function Modal's onDismiss prop.
    1. Set Modal's visible props is true. (show Modal)
    1. Set Modal's visible props is false. (close Modal)
    1. The set function in onDismiss is called.
    kkoudev authored and sandfox committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    2692b92 View commit details
    Browse the repository at this point in the history