Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Linking examples in rn-tester #30547

Closed
wants to merge 1 commit into from
Closed

Add Linking examples in rn-tester #30547

wants to merge 1 commit into from

Conversation

utkarsh-dixit
Copy link
Contributor

@utkarsh-dixit utkarsh-dixit commented Dec 7, 2020 •
edited
Loading

Summary

Added examples to RNTester for the Linking API.

Changelog

[General] [Added] - Added example for openSettings() for Linking API.
[General] [Added] - Added LSApplicationQueriesSchemes in info.plist with entries tel, telprompt, http, fb, geo

Test Plan

Screen Recording 2020-12-07 at 11 19 13 PM (1)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 7, 2020
@pull-bot
Copy link

pull-bot commented Dec 7, 2020 •
edited
Loading

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against ba47395

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Dec 7, 2020
@rickhanlonii
Copy link
Member

Can you add a screenshot?

@rickhanlonii
Copy link
Member

Looks like the JSC test is failing, going to re-run the test and see if it's an infra error

@hramos
Copy link
Contributor

hramos commented Dec 28, 2020

Looks like the failing iOS test is due to 'FBReactNativeSpec/FBReactNativeSpec.h' file not found. This file is generated by the codegen at build time. Can you rebase your project on top of the latest master and run the iOS tests again?

You should be able to run the tests locally using:

# react-native/
npm install
(cd packages/rn-tester && pod install)
./scripts/objc-test.sh test

@lunaleaps lunaleaps self-assigned this Aug 25, 2021
@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lunaleaps
Copy link
Contributor

@utkarsh-dixit Is this only for iOS?

lunaleaps
lunaleaps reviewed Aug 25, 2021
View reviewed changes
packages/rn-tester/RNTester/Info.plist
@@ -2,6 +2,14 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>LSApplicationQueriesSchemes</key>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do something equivalent for Android

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, so this example was already working for Android but now is adding support for iOS? Should we rename the example component?

@facebook-github-bot
Copy link
Contributor

@lunaleaps merged this pull request in b26f277.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunaleaps lunaleaps lunaleaps left review comments

Assignees

@lunaleaps lunaleaps

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@utkarsh-dixit @pull-bot @rickhanlonii @hramos @facebook-github-bot @lunaleaps @react-native-bot