Fix 1-pixel height horizontal line disappear

[laotian]

Summary

On Android devices with a non integer DPI (for example, 2.75), View layoutX/Y may be decimal (for example, 3.25). Using integer type in recursive calculation may cause 1 pixel margin or 1 pixel overlap between adjacent views. The dividing line of 1 pixel (StyleSheet.hairlineWidth) may disappear.

Fixes #22927

Changelog

[Android] [Fixed] - Fix 1-pixel height horizontal line disappear.

Test Plan

manual test
first repeats the problem according to the demo code, and verifies after repair

reproduce steps

• APP don't use FabricUIManager
• Dividing line, width/height set to 1 pixel(StyleSheet.hairlineWidth)
• Adjacent view opaque
• Android devices with a non integer DPI (for example, 2.75)

demo code

import React,{Component} from 'react';
import {StyleSheet, View, Text} from 'react-native';

export default class App extends Component{
  // some line disappear on decimal dpi Android device
  render() {
    return (
        <View>
          {['1','2','3','4','5','6'].map((row, index) => (
              <View>
                <View style={{height: 54, flexDirection: 'row', alignItems: 'center', backgroundColor: '#ffffff' }}>
                    {['1','2','3','4','5','6'].map(column=>{
                        return(
                            <View style={{flexDirection: 'row'}}>
                                <View style={{width: 61, backgroundColor: '#ffffff', justifyContent: 'center', alignItems: 'center'}}>
                                    <Text>{`R${row}C${column}`}</Text>
                                </View>
                                <View style={{width: StyleSheet.hairlineWidth,backgroundColor: '#ff0000' }} />
                            </View>)
                    })}
                </View>
                <View style={{height: StyleSheet.hairlineWidth,backgroundColor: '#ff0000'}} />
              </View>
          ))}
        </View>);
  }
};

Screenshot

Before Fix

device : Android MI8SE (dpi 2.75)

Fixed

[facebook-github-bot]

Hi @laotian!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[ecreeth]

You should update the comment as well

[laotian]

I have update the comment, thank you

[laotian]

@ecreeth I have update the comment and I submitted in the original branch. Do I need to launch a new PR?

[laotian]

@ecreeth Can you review my commit again?

[ecreeth]

cc @safaiyeh

[laotian]

@safaiyeh Can you review my PR?

[kelset]

Based on file history, looks like @mdvacca is the most relevant FB dev to check/review this PR out.

cc @dulmandakh

[mdvacca]

Thanks for working on this @laotian, I'm importing to review internally.

[facebook-github-bot]

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR was closed because it has been stalled for 7 days with no activity.

[ddikodroid]

Thanks for working on this @laotian, I'm importing to review internally.

any update on this pull request?

[react-native-bot]

	Fails
🚫	📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Generated by 🚫 dangerJS against 6289a2e