Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal example #30406

Closed
wants to merge 6 commits into from
Closed

Conversation

suminkimm
Copy link
Contributor

Summary

Add examples for Modal component in RNTester for:

Changelog

[General] [Add] - Added examples for Modal component in RNTester

Test Plan

Example GIF

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 17, 2020
@pull-bot
Copy link

pull-bot commented Nov 17, 2020

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 98286f5

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 68a4761

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,508,305 -17,323
android hermes armeabi-v7a 7,099,817 -11,054
android hermes x86 7,946,238 -19,854
android hermes x86_64 7,857,277 -20,111
android jsc arm64-v8a 8,972,427 -17,455
android jsc armeabi-v7a 8,547,052 -11,182
android jsc x86 8,971,859 -19,988
android jsc x86_64 9,523,158 -20,242

Base commit: 68a4761

@suminkimm
Copy link
Contributor Author

@rickhanlonii The only failing test is test_ios_unit_frameworks_hermes which was failing on master!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@PeteTheHeat
Copy link
Contributor

Thanks for working on this :)

Just checking, did you test on iOS as well? (since the diff makes some iOS specific changes, and I don't see that in your test plan)

@suminkimm
Copy link
Contributor Author

Thanks for working on this :)

Just checking, did you test on iOS as well? (since the diff makes some iOS specific changes, and I don't see that in your test plan)

@PeteTheHeat Yup, I've tested it on iOS as well.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @suminkimm in 8dddaa8.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 10, 2020
@rickhanlonii rickhanlonii deleted the add-modal-example branch December 15, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants