Add mocks to fix: handleException is not a function (#29849)

[lukewlms]

Summary

This solves two problems:

1. When an exception is thrown by RN code during testing (e.g. with react-native-testing-library), the exception message is swallowed and instead this message is shown:

ExceptionsManager.handleException is not a function

2. The inline require call that is removed in this commit is also incompatible with running a test suite (at least in react-native-testing-library) because the on-the-fly require fails. This throws the error:

ReferenceError: You are trying to import a file after the Jest environment has been torn down.

See issue: #29849

Changelog

[General] [Fix] - Fix issue where exceptions thrown during test runs could get swallowed and result in these messages:

• ExceptionsManager.handleException is not a function
• ReferenceError: You are trying to import a file after the Jest environment has been torn down.

Test Plan

Before: an exception generated during our test suite is swallowed and shows the errors above
After: no longer repros. exceptions logged during a test run output their messages to the console as expected

(I def would like verification from a code owner here, this code makes it work but I can't guarantee it's optimal. Thanks!)

[pull-bot]

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 3ea724d

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: abff021

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,367,878	0
android	hermes	armeabi-v7a	6,994,962	0
android	hermes	x86	7,808,374	0
android	hermes	x86_64	7,699,928	0
android	jsc	arm64-v8a	9,512,923	0
android	jsc	armeabi-v7a	9,132,155	0
android	jsc	x86	9,379,011	0
android	jsc	x86_64	9,959,933	0

Base commit: abff021

[Panda-ref]

It'll result in

Require cycle: node_modules/react-native/Libraries/Core/ExceptionsManager.js ->
 node_modules/react-native/Libraries/LogBox/Data/LogBoxData.js ->
 node_modules/react-native/Libraries/Core/ExceptionsManager.js

[eliw00d]

This was originally in reportLogBoxError to avoid a circular dependency. If you move it back into reportLogBoxError, but keep the mock in jest/setup, does it still solve the issue?

[lukewlms]

Thanks for taking a look. In my experience this change is necessary to avoid Jest throwing:

ReferenceError: You are trying to import a file after the Jest environment has been torn down.

I'm not sure how to resolve the circular dependency issue :\

[wcandillon]

I can confirm that this fixes the issue, how can we follow in which version of RN this fix will land?

[owencraston]

It would be great to get this error blocks a lot of apps that have testing infrastructure set up to upgrade.

[safaiyeh]

@rickhanlonii could you take a look at this?

[rickhanlonii]

Hey @lukewlms, thanks for working on this!

Looks like the tests are failing and @eliw00d is correct that we will need some other way to resolve the circular dependency.

[semcelik]

Is there any update or workaround on this bug?

[lukewlms]

@semcelik Yes, this workaround is correcting the issue for us.

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR was closed because it has been stalled for 7 days with no activity.