feat: Enable Hermes to work on iOS

packages/rn-tester/RNTesterPods.xcodeproj/project.pbxproj

@@ -589,7 +589,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "export NODE_BINARY=node\nexport PROJECT_ROOT=$SRCROOT/..\nexport SOURCEMAP_FILE=../sourcemap.ios.map\n# export FORCE_BUNDLING=true\n\"$SRCROOT/../../scripts/react-native-xcode.sh\" $SRCROOT/../../packages/rn-tester/js/RNTesterApp.ios.js\n";
+			shellScript = "export NODE_BINARY=node\nexport SOURCEMAP_FILE=../sourcemap.ios.map\n# export FORCE_BUNDLING=true\n\"$SRCROOT/../../scripts/react-native-xcode.sh\" $SRCROOT/../../packages/rn-tester/js/RNTesterApp.ios.js\n";
 		};
 		7A5E3C3F59BF3EA884A39149 /* [CP] Embed Pods Frameworks */ = {
 			isa = PBXShellScriptBuildPhase;

scripts/hermes-binary.sh

@@ -0,0 +1,17 @@
+#!/bin/bash
+# Copyright (c) Facebook, Inc. and its affiliates.
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+
+[ -z "$HERMES_PATH" ] && export HERMES_PATH="$REACT_NATIVE_DIR/../hermes-engine-darwin"
+
+export HERMES_CLI = "$HERMES_PATH/destroot/bin/hermesc"
+
+if [[ $USE_HERMES == true && ! -d "$HERMES_PATH" ]]; then
+  echo "error: Can't find Hermes executable - directory `$HERMES_PATH` doesn't exist. " \
+       "If you have a non-standard project structure, select your project in Xcode, find " \
+       "'Build Phases' - 'Bundle React Native code and images' and set `HERMES_PATH` to an " \
+       "absolute path to a `hermes-engine-darwin` package inside your `node_modules`" >&2
+  exit 2
+fi

scripts/react-native-xcode.sh

@@ -116,14 +116,15 @@ REACT_NATIVE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 # shellcheck source=/dev/null
 source "$REACT_NATIVE_DIR/scripts/node-binary.sh"
 
+# check and assign HERMES_CLI env
+source "$REACT_NATIVE_DIR/scripts/hermes-binary.sh"
+
 [ -z "$NODE_ARGS" ] && export NODE_ARGS=""
 
 [ -z "$CLI_PATH" ] && export CLI_PATH="$REACT_NATIVE_DIR/cli.js"
 
 [ -z "$BUNDLE_COMMAND" ] && BUNDLE_COMMAND="bundle"
 
-[ -z "$HERMES_PATH" ] && HERMES_PATH="$PROJECT_ROOT/node_modules/hermes-engine-darwin/destroot/bin/hermesc"
-
 [ -z "$COMPOSE_SOURCEMAP_PATH" ] && COMPOSE_SOURCEMAP_PATH="$REACT_NATIVE_DIR/scripts/compose-source-maps.js"
 
 if [[ -z "$BUNDLE_CONFIG" ]]; then
@@ -145,11 +146,6 @@ case "$PLATFORM_NAME" in
     ;;
 esac
 
-USE_HERMES=
-if [[ "$BUNDLE_PLATFORM" == "macos" && -f "$HERMES_PATH" ]]; then
-  USE_HERMES=true
-fi
-
 EMIT_SOURCEMAP=
 if [[ ! -z "$SOURCEMAP_FILE" ]]; then
   EMIT_SOURCEMAP=true
@@ -190,7 +186,7 @@ else
     EXTRA_COMPILER_ARGS="$EXTRA_COMPILER_ARGS -output-source-map"
   fi
   HBC_FILE="$CONFIGURATION_BUILD_DIR/$(basename $BUNDLE_FILE)"
-  "$HERMES_PATH" -emit-binary $EXTRA_COMPILER_ARGS -out "$HBC_FILE" "$BUNDLE_FILE"
+  "$HERMES_CLI" -emit-binary $EXTRA_COMPILER_ARGS -out "$HBC_FILE" "$BUNDLE_FILE"
   mv "$HBC_FILE" "$DEST/"
   BUNDLE_FILE="$DEST/main.jsbundle"
   if [[ $EMIT_SOURCEMAP == true ]]; then