-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react.gradle #28776
Update react.gradle #28776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
welp
FYI we took this code straight from the CLI where we use |
The CI jobs are failing because this branch was opened on the main repo. In the future, you'll be better off if you create branches on your fork instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @grabbou in afdcdc7. When will my fix make it into a release? | Upcoming Releases |
Cool. Didn't know this was the reason! |
Summary: Running `./gradlew assembleRelease` fails as the path to the CLI contains a new line at the end. We don't run this command in `debug` mode, hence it passed the testing. My bad. Fixed, checked in both `debug` with `bundleInDebug: true` and `release`. Fixes #28700 ## Changelog [INTERNAL] [ANDROID] - Fix `React.gradle` to build Android apps in production Pull Request resolved: #28776 Test Plan: Running `./gradlew assembleRelease` works Reviewed By: hramos Differential Revision: D21287789 Pulled By: TheSavior fbshipit-source-id: dc3ec8eef7a919b072b562d2bd455e2f704bc083
Summary
Running
./gradlew assembleRelease
fails as the path to the CLI contains a new line at the end. We don't run this command indebug
mode, hence it passed the testing. My bad.Fixed, checked in both
debug
withbundleInDebug: true
andrelease
.Fixes #28700
Changelog
[INTERNAL] [ANDROID] - Fix
React.gradle
to build Android apps in productionTest Plan
Running
./gradlew assembleRelease
works