Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react.gradle #28776

Closed
wants to merge 1 commit into from
Closed

Update react.gradle #28776

wants to merge 1 commit into from

Conversation

grabbou
Copy link
Contributor

@grabbou grabbou commented Apr 28, 2020

Summary

Running ./gradlew assembleRelease fails as the path to the CLI contains a new line at the end. We don't run this command in debug mode, hence it passed the testing. My bad.

Fixed, checked in both debug with bundleInDebug: true and release.

Fixes #28700

Changelog

[INTERNAL] [ANDROID] - Fix React.gradle to build Android apps in production

Test Plan

Running ./gradlew assembleRelease works

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Apr 28, 2020
Copy link
Contributor

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welp

@grabbou
Copy link
Contributor Author

grabbou commented Apr 28, 2020

FYI we took this code straight from the CLI where we use Runtime.getRuntime().exec() and that one seems to be handling whitespaces automatically, unlike commandLine from Gradle.

@elicwhite
Copy link
Member

The CI jobs are failing because this branch was opened on the main repo. In the future, you'll be better off if you create branches on your fork instead.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @grabbou in afdcdc7.

When will my fix make it into a release? | Upcoming Releases

@grabbou
Copy link
Contributor Author

grabbou commented Apr 29, 2020

The CI jobs are failing because this branch was opened on the main repo. In the future, you'll be better off if you create branches on your fork instead.

Cool. Didn't know this was the reason!

grabbou added a commit that referenced this pull request Apr 29, 2020
Summary:
Running `./gradlew assembleRelease` fails as the path to the CLI contains a new line at the end. We don't run this command in `debug` mode, hence it passed the testing. My bad.

Fixed, checked in both `debug` with `bundleInDebug: true` and `release`.

Fixes #28700

## Changelog

[INTERNAL] [ANDROID] - Fix `React.gradle` to build Android apps in production
Pull Request resolved: #28776

Test Plan: Running `./gradlew assembleRelease` works

Reviewed By: hramos

Differential Revision: D21287789

Pulled By: TheSavior

fbshipit-source-id: dc3ec8eef7a919b072b562d2bd455e2f704bc083
@yungsters yungsters deleted the fix/gradle-release branch July 15, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.63-rc.0] Android release builds fail on new init projects
5 participants