Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RTL in RTLExample when Platform != android #28742

Closed
wants to merge 1 commit into from

Conversation

kmelmon
Copy link
Contributor

@kmelmon kmelmon commented Apr 23, 2020

Summary

This change upstreams a small change we did in react-native-windows to allow the RTLExample RNTester page to function correctly on Windows. The change is part of this Pr:
microsoft/react-native-windows#4683
Currently the direction property is gated behind a check for Platform == 'iOS', which means it only works on iOS. Windows supports direction = 'rtl' so I've chanced this check to Platform != 'android'.

Changelog

[Internal] [Changed] - Changed RTLExample RNTester page to use direction = 'rtl' when Platform is not Android.

Test Plan

Confirmed this change works correctly in RNTester on Windows. Have not confirmed iOS as I don't have Mac hardware.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,743,076 0
android hermes armeabi-v7a 6,408,057 0
android hermes x86 7,124,988 0
android hermes x86_64 7,015,358 0
android jsc arm64-v8a 8,911,716 0
android jsc armeabi-v7a 8,569,071 0
android jsc x86 8,736,752 0
android jsc x86_64 9,312,764 0

Base commit: ca16256

@analysis-bot
Copy link

analysis-bot commented Apr 23, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ca16256

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @kmelmon in fa69356.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants