change onRefresh flow typing #28167
Closed
change onRefresh flow typing #28167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
RNTester (Android/hermes/arm64-v8a): 3291136 bytes |
|
RNTester.app (iOS): 10657792 bytes |
There was a problem hiding this comment.
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @vonovak in 884c86a. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: I propose this change because we (and a lot of other people, I'd guess) pass an `async` function as a parameter to `onRefresh`. Because the `async` function returns a `promise`, flow is reporting an error. I think the type checking here can be relaxed either all the way to `any` (because RN does not care here what we return) or to `void | Promise<void>` to account for async functions. looking at facebook@fb7b2d3#diff-a9c5687ae65236ba3e7f34bfdcdec81d seems like the second is preferred ## Changelog [General] [changed] - relax RefreshControl's onRefresh flow typing Pull Request resolved: facebook#28167 Test Plan: * flow passes Reviewed By: hramos Differential Revision: D20196529 Pulled By: TheSavior fbshipit-source-id: bb5a314bcfb5fb9c8ab71eccb449f1322aeebacb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I propose this change because we (and a lot of other people, I'd guess) pass an
asyncfunction as a parameter toonRefresh. Because theasyncfunction returns apromise, flow is reporting an error. I think the type checking here can be relaxed either all the way toany(because RN does not care here what we return) or tovoid | Promise<void>to account for async functions.looking at fb7b2d3#diff-a9c5687ae65236ba3e7f34bfdcdec81d seems like the second is preferred
Changelog
[General] [changed] - relax RefreshControl's onRefresh flow typing
Test Plan