Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Remove pickFirst arguments #27964

Closed
wants to merge 1 commit into from
Closed

[Android] Remove pickFirst arguments #27964

wants to merge 1 commit into from

Conversation

passy
Copy link
Member

@passy passy commented Feb 5, 2020

Summary

This is no longer necessary with the new Flipper release.

Test Plan

This was a built-time problem so the CI jobs would catch this.

Changelog

[Android] [Removed] - pickFirst options for RNTester and template

Summary:
This is no longer necessary with the new Flipper release.

Test Plan:
Hoping that Rick helps me out here.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 5, 2020
Copy link
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@passy is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @passy in 4bb0b4f.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 10, 2020
@hramos hramos deleted the pickfirst-removal branch February 25, 2020 19:16
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
Summary:
This is no longer necessary with the new Flipper release.
Pull Request resolved: facebook#27964

Test Plan:
This was a built-time problem so the CI jobs would catch this.

## Changelog

[Android] [Removed] - pickFirst options for RNTester and template

Differential Revision: D19815829

Pulled By: passy

fbshipit-source-id: d8f66e64e7e922b8ea18ad6eeec3a1c8e6bc77fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: Android Android applications. Type: Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants