Remove NativeRunnableDeprecated #27529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The class was deprecated in 2016 and is blocking an upgrade to fbjni which no longer supports the `Countable` class this extends. Changelog: [Android] [Removed] - NativeRunnableDeprecated Test Plan: No references to it in this codebase.
facebook-github-bot
added
CLA Signed
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @passy in 973253a. When will my fix make it into a release? | Upcoming Releases |
rickhanlonii
pushed a commit
that referenced
this pull request
Feb 5, 2020
Summary: The class was deprecated in 2016 and is blocking an upgrade to fbjni which no longer supports the `Countable` class this extends. Changelog: [Android] [Removed] - NativeRunnableDeprecated Pull Request resolved: #27529 Test Plan: No references to it in this codebase. Reviewed By: mdvacca Differential Revision: D19087074 Pulled By: passy fbshipit-source-id: a4ee73be7c13cedf1d86d2643f8e788ad4a2e31f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The class was deprecated in 2016 and is blocking an upgrade to fbjni
which no longer supports the
Countableclass this extends.Changelog:
[Android] [Removed] - NativeRunnableDeprecated
Test Plan:
No references to it in this codebase.