Enable dev keyboard shortcuts on Mac Catalyst #27479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
andymatuschak
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Ah, I suspected it was something like this, but I failed to track it down in #27469. Thank you! These changes do indeed appear to be what's required.
|
Ping! #27469 was merged! |
facebook-github-bot
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @charpeni in 56dfc86. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: This enables the dev menu to bo opened from keyboard shortcuts in dev from a Mac Catalyst app. cc TheSavior andymatuschak radex ## Changelog [iOS] [Fixed] - Enable dev keyboard shortcuts on Mac Catalyst Pull Request resolved: facebook#27479 Test Plan: It depends on facebook#27469 (to have working WebSocket in debug).  Differential Revision: D19576528 Pulled By: shergin fbshipit-source-id: 32b4f8424fb7d270640af4bc50dba24f488bef4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This enables the dev menu to bo opened from keyboard shortcuts in dev from a Mac Catalyst app.
cc @TheSavior @andymatuschak @radex
Changelog
[iOS] [Fixed] - Enable dev keyboard shortcuts on Mac Catalyst
Test Plan
It depends on #27469 (to have working WebSocket in debug).