-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump gradle to 6.0.1 #27290
bump gradle to 6.0.1 #27290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @dulmandakh in 701e66b. When will my fix make it into a release? | Upcoming Releases |
Thanks @dulmandakh 👌 |
Is not there any changes in for example
have been changed to:
and these lines have been removed from my file
|
I use gradle wrapper command to make sure that scripts are updated |
Summary: This PR is related to #27290. I just upgraded my project's Gradle wrapper version to 6.0.1 and I realized some files have some differences with the files in react-native `template` folder. so I create this PR to apply differences. the main difference is in the `gradlew` file. I'm not familiar with Linux shell scripts but it seems there was a syntax error in `case` items syntax. `(` should not be used in declaring case's items. it may has building error in Linux OS. ## Changelog [Android] [Fixed] - Applied missing changes from bumping Gradle wrapper to 6.0.1 Pull Request resolved: #27639 Test Plan: I have no Linux OS right now, so I can't directly test these changes, but because the changes have made by running `gradlew wrapper` command, it should not break CI. (I hope :) ) Differential Revision: D19341671 Pulled By: cpojer fbshipit-source-id: ccfc3c12af3f5468671737e5ba0b1674b4491590
…k#27639) Summary: This PR is related to facebook#27290. I just upgraded my project's Gradle wrapper version to 6.0.1 and I realized some files have some differences with the files in react-native `template` folder. so I create this PR to apply differences. the main difference is in the `gradlew` file. I'm not familiar with Linux shell scripts but it seems there was a syntax error in `case` items syntax. `(` should not be used in declaring case's items. it may has building error in Linux OS. ## Changelog [Android] [Fixed] - Applied missing changes from bumping Gradle wrapper to 6.0.1 Pull Request resolved: facebook#27639 Test Plan: I have no Linux OS right now, so I can't directly test these changes, but because the changes have made by running `gradlew wrapper` command, it should not break CI. (I hope :) ) Differential Revision: D19341671 Pulled By: cpojer fbshipit-source-id: ccfc3c12af3f5468671737e5ba0b1674b4491590
Summary
Bump Gradle to 6.0.1, which has Java 13 support and many improvements. But also it'll help us to clean up deprecation warnings.
Changelog
[Android] [Changed] - bump Gradle to 6.0.1
Test Plan
RNTester app builds and runs as expected