Fix spinner is not shown on beginRefreshingProgrammatically on IOS #27236
Conversation
|
Hi IgnorancePulls! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Any update regarding this PR? |
|
@ninjaengineers can you fix the conflict in RCTRefreshControl.m? It would be useful to also have some screenshot or video that demonstrates the issue as well as the resulting fix. |
@hramos unfortunately, I only do javascript; however, can we please ask @IgnorancePulls to review his PR and resolve the conflicts? |
|
@ghsdh3409 thank you! |
|
@IgnorancePulls can you fix the conflict in |
|
@IgnorancePulls Could you resolve merge conflict? |
Unfortunately i would not be able to do it any time soon, could you take it over from here? |
|
@IgnorancePulls Okay. But, I have no authorization for this PR. Can I open new PR for this change? |
|
Waiting to get this fix soon. Thanks! |
|
@IgnorancePulls @hramos @ghsdh3409 |
|
@nnabinh Good! Thanks! |
…27397) Summary: It closes #24855 In the endRefreshProgrammatically of RCTRefreshControl.m there is calculation for content offset when spinner is shown CGPoint offset = {scrollView.contentOffset.x, scrollView.contentOffset.y - self.frame.size.height}; However self.frame.size.height is always 0 and therefore spinner is not visible This change should fix that Since the owner of the following PR is quite busy and won't be able to resolve the merge conflict anytime soon, I created this PR here to get the fix merged soon. Ref: #27236 Thanks to [IgnorancePulls](https://github.com/IgnorancePulls) ## Changelog [iOS] [Fixed] - Fix spinner visibility on beginRefreshingProgrammatically Pull Request resolved: #27397 Test Plan: IOS tests passed Check whether this issue is reproduced or not for the repro which is described inside the issue. #24855 Reviewed By: sammy-SC Differential Revision: D18801307 Pulled By: hramos fbshipit-source-id: d12af236778441a136dbe6b03dfd3495a465ae0f
|
This PR was reopened and merged in #27397. |
Summary
It closes #24855
In the endRefreshProgrammatically of RCTRefreshControl.m there is calculation for content offset when spinner is shown
CGPoint offset = {scrollView.contentOffset.x, scrollView.contentOffset.y - self.frame.size.height};However
self.frame.size.heightis always 0 and therefore spinner is not visibleThis change should fix that
Changelog
[iOS] [Fixed] - Fix spinner visibility on
beginRefreshingProgrammaticallyTest Plan
IOS tests passed
Check whether this issue is reproduced or not for the repro which is described inside the issue.
#24855