Fix scrollIndicatorInsets on iOS 13

[radex]

Summary

scrollIndicatorInsets seems to be broken on iOS 13. I think this might be an iOS bug? Or maybe a behavior change. Either way, it's a regression for React Native users. Setting automaticallyAdjustsScrollIndicatorInsets = NO fixes the behavior + we stop using deprecated scrollIndicatorInsets if possible

Changelog

[iOS] [Fixed] - Fixed ScrollView's scrollIndicatorInsets prop on iOS 13

Test Plan

• RNTester → scrollView - both horizontal and vertical examples have insets set to 50px on both sides

[sammy-SC]

Hello @radex,

thank you for the PR. I am unable to reproduce the problem, could you please send me a repro so I can verify that this fix works?

[sammy-SC]

I don't think it is to have conditional compilation together with @available(iOS 13.0, *) check.
Using @available(iOS 13.0, *) is preferred.

This applies to the code below as well.

[radex]

I think it is, and it seems to be a convention in RN project.

@available(iOS 13.0, *) is a runtime check, and #if ... __IPHONE_OS_VERSION_MAX_ALLOWED check is for SDK the project is compiled against.

I can re-check but I think if you tried to compile this code in Xcode 10.2 or earlier, it would fail to compile

[hramos]

I believe @radex may be referring to RCTAppearance.mm where I used this pattern as Dark Mode is new to iOS 13:

react-native/React/CoreModules/RCTAppearance.mm

Lines 28 to 29 in aff6bad

	#if defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && defined(__IPHONE_13_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_13_0
	if (@available(iOS 13.0, *)) {

@sammy-SC do you still want this change to be made?

[sammy-SC]

@hramos is there any reason to have conditional compilation there? If not, then let's remove it.

[SYoder1]

Is there any status update on this PR?

[lunaleaps]

I believe this has been resolved by #29809 so will close this for now.