-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint-config dependencies #27085
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let me try to land this at FB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @friederbluemle in 1353da5. When will my fix make it into a release? | Upcoming Releases |
Thanks for update, |
@relign - Sorry can you clarify what you mean by "can be reflected in the commit"? As of today, |
@friederbluemle I think the update of |
When will version 0.0.6 of |
@fabianbru - That's a great question. Note also that a new version of Maybe @TheSavior, @michalchudziak or @matt-oakes has more information? |
@friederbluemle As far as I know, the ESLint package is not tied to a React Native release cycle and can be released at any time. I think someone just needs to run the release command manually on their machine. |
@hramos do you know how to do a release of this package? |
@TheSavior just npm publish it. |
@matt-oakes could you do the honours, please? it looks like it's just you and mike866 who are collaborators on https://www.npmjs.com/package/@react-native-community/eslint-config |
I think that's done. Really, this should be moved to the |
@matt-oakes the reason I would prefer keeping it within the RN repo is that we actually use this config within RN and within FB. Externalizing it to another repo on GitHub will make our setup more complex. |
@cpojer I think that makes sense. Maybe there needs to be a better process for ensuring changes to the config actually end up being published once a PR lands? I'm not sure what that process would actually be though. Maybe you could add me to the |
Sounds great, do you mind sending a PR? |
Summary: Adding myself as a code owner for the files in the ESLint package so I get email alerts for all PRs which alter the package. This is needed because I need to manually publish updates to the package when pull requests are merged in. They are not handled by the standard React Native release cycle. Related discussion: #27085 (comment) ## Changelog [Internal] [Added] - Added mat-oakes as a CODEOWNER for the ESLint package Pull Request resolved: #27689 Test Plan: N/A Differential Revision: D19294768 Pulled By: cpojer fbshipit-source-id: 3e3833261fc0b3c107b52b0e8232bd942a2ecaf4
Summary: Adding myself as a code owner for the files in the ESLint package so I get email alerts for all PRs which alter the package. This is needed because I need to manually publish updates to the package when pull requests are merged in. They are not handled by the standard React Native release cycle. Related discussion: facebook#27085 (comment) ## Changelog [Internal] [Added] - Added mat-oakes as a CODEOWNER for the ESLint package Pull Request resolved: facebook#27689 Test Plan: N/A Differential Revision: D19294768 Pulled By: cpojer fbshipit-source-id: 3e3833261fc0b3c107b52b0e8232bd942a2ecaf4
Summary
A couple of minor and patch updates to the
eslint-config
package, to avoid warnings and errors with the generated code of the latest RN version templates, such as:yarn check
outputs the following errors:By adding the missing
"license"
field, from now on this also avoids the following warnings:Changelog
[General] [Fixed] - Fix eslint-config peer dependency warnings
Test Plan
master
package locally (0.0.6
is not published yet!)eslint-config
to local package, observe errors/warnings runningyarn
/yarn check
yarn lint
passes cleanlyeslint-config
package, observe no more errorsyarn lint
still passes cleanly