[ScrollView] Handle dissmissKeyboardMode="on-drag" for Android

[azanli]

Summary

dismissKeyboardMode="on-drag" prop for Android's ScrollView does not work as expected according to the docs. This problem has been verified in #23364 and from personal tests.

Changelog

[Android] [Fixed] - Handle dissmissKeyboardMode="on-drag" for Android

Test Plan

with fix & without fix

[janicduplessis]

The fix seems fine but the need for it seems to come from another issue. Do you know why this.state.isTouching is not true while scrolling? It is supposed to get set here https://github.com/facebook/react-native/blob/master/Libraries/Components/ScrollResponder.js#L389.

Looks like it gets called in onTouchStart here

react-native/Libraries/Components/ScrollView/ScrollView.js

Line 1137 in 361697e

onTouchStart: this._scrollResponder.scrollResponderHandleTouchStart,

, is it possible this never gets called on Android?

[azanli]

I was trying to figure out why this.state.isTouching is not true and I came to the conclusion that this.state isn't sharing the same context. If you look around, this.state.isTouching isn't set anywhere in ScrollView.js. I also tried checking against this._scrollResponder.state.isTouching and state wasn't reachable which makes sense because the ScrollView class only copies over the properties but isn't instantiated from ScrollResponder.

I'm not sure whether onTouchStart ever gets called on Android but my assessment was that onScrollBeginDrag is essentially the same. Either way, it makes sense to move any operations out of onScroll if possible. Also, the property value on-drag synergizes with onScrollBeginDrag.

[vorasudh]

I am facing the same issue and looking forward to this merge.

[janicduplessis]

The change makes sense on its own, even if it doesn't fix the underlying cause of the issue so I'm fine with it.

We should probably try to investigate why isTouching isn't working later as it might cause other bugs.

[fungilation]

Nice patch! Works and fixes #23364 indeed on Andoird. On RN 0.60.5

[facebook-github-bot]

@sahrens is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[sahrens]

Thanks for the fix, and thanks for the review @janicduplessis - if you're ok with it, I'm ok with it :)

[fungilation]

Can we get this merged please? I reproduced issue on android in my app, which this PR fixes. I've been monkey patching (patch-package) RN for months now to get this fix.

[rtman]

This is still an issue, can we get this merged?

[janicduplessis]

updated the fix in #31943

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This PR was closed because it has been stalled for 7 days with no activity.