Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check to handle all cases of MissingWebViewPackageException #26189

Closed
wants to merge 6 commits into from
Closed

Added check to handle all cases of MissingWebViewPackageException #26189

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5438b0
Added check for webview in error message to avoid crash
Aug 26, 2019
ec37c1b
Added check to catch all kinds of MissingWebViewPackageException errors
Aug 27, 2019
35a2ce0
Updated source file link
Aug 27, 2019
4bef96b
Checking for canonical class name instead of error message.
Sep 8, 2019
63102cc
Fixed syntax error
Sep 11, 2019
77b2f4f
Fixed syntax error
Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/modules/network/ForwardingCookieHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ protected void doInBackgroundGuarded(Void... params) {
// We cannot catch MissingWebViewPackageException as it is in a private / system API
// class. This validates the exception's message to ensure we are only handling this
// specific exception.
// https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/webkit/WebViewFactory.java#98
if (message != null && message.contains("No WebView installed")) {
// https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/webkit/WebViewFactory.java#348
if (message != null && (exception.getClass().getCanonicalName().equals("android.webkit.WebViewFactory.MissingWebViewPackageException")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you actually check this code and whether it works? The code here has a syntax error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer Sorry for the syntax error. I had actually tested this code in our internal fork. Made this mistake while committing here. Fixing this.

return null;
} else {
throw exception;
Expand Down